wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-28 01:30:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "EventPresentationModel: Cache the result of getBundledEvents()"

Browse source
This commit is contained in:
jenkins-bot 2015-11-25 18:39:01 +00:00 committed by Gerrit Code Review
parent 23734e3539 104075d2d4
commit a8171d1f75
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
includes/formatters/EventPresentationModel.php
View file

@ -27,6 +27,11 @@ abstract class EchoEventPresentationModel {
*/ */
private $user; private $user;
/**
* @var EchoEvent[]|null
*/
private $bundledEvents;
/** /**
* @param EchoEvent $event * @param EchoEvent $event
* @param Language|string $language * @param Language|string $language
@ -88,17 +93,20 @@ abstract class EchoEventPresentationModel {
if ( !$this->event->getBundleHash() ) { if ( !$this->event->getBundleHash() ) {
return array(); return array();
} }
if ( $this->bundledEvents !== null ) {
return $this->bundledEvents;
}
// FIXME: We really shouldn't be making db queries like this // FIXME: We really shouldn't be making db queries like this
// in the presentation model // in the presentation model
$eventMapper = new EchoEventMapper(); $eventMapper = new EchoEventMapper();
$events = $eventMapper->fetchByUserBundleHash( $this->bundledEvents = $eventMapper->fetchByUserBundleHash(
$this->user, $this->user,
$this->event->getBundleHash() $this->event->getBundleHash()
// default params: web, DESC, limit=250 // default params: web, DESC, limit=250
); );
return $events; return $this->bundledEvents;
} }
/** /**