wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-28 01:30:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix PHP 8.1 compatibility issue in ForeignNotifications

Browse source 
Passing null to functions that expect a string is no longer allowed.
Here in this code it can apparently only happen in test scenarios.
That's why I use a very minimal workround that still calls the same
code. The lookup will return an empty string and trigger the expected
code path below.

Bug: T311448
Change-Id: If04924a22b82ae29b8f9327668e8965d6d2a490d
This commit is contained in:
thiemowmde 2022-11-08 20:53:54 +01:00
parent ed49fb3203
commit 9ab1d92c9c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/ForeignNotifications.php
View file

@ -243,7 +243,7 @@ class EchoForeignNotifications {
// try to fetch site name for this specific wiki, or fallback to the // try to fetch site name for this specific wiki, or fallback to the
// general project's sitename if there is no override // general project's sitename if there is no override
$wikiName = $wgConf->get( 'wgSitename', $wikiId ) ?: $wgConf->get( 'wgSitename', $site ); $wikiName = $wgConf->get( 'wgSitename', $wikiId ) ?: $wgConf->get( 'wgSitename', $site );
$langName = Language::fetchLanguageName( $langCode, $wgLang->getCode() ); $langName = Language::fetchLanguageName( $langCode ?? '', $wgLang->getCode() );
if ( !$langName ) { if ( !$langName ) {
// if we can't find a language name (in language-agnostic // if we can't find a language name (in language-agnostic