From 44a015970fc0d343d98d0045e4b596896c80f596 Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Fri, 25 Mar 2016 11:47:00 -0700 Subject: [PATCH] jscs: Add "checkTypes": "strictNativeCase" and make pass Change-Id: I4be0d72ba192f0b79a92f5efa2f5a16fb0f327b5 --- .jscsrc | 1 + modules/api/mw.echo.api.EchoApi.js | 8 ++++---- modules/logger/mw.echo.Logger.js | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.jscsrc b/.jscsrc index 7d200f2b5..ea5a127ae 100644 --- a/.jscsrc +++ b/.jscsrc @@ -10,6 +10,7 @@ }, "requireParamTypes": true, "checkReturnTypes": true, + "checkTypes": "strictNativeCase", "requireReturnTypes": true, "checkRedundantAccess": true, "requireNewlineAfterDescription": true diff --git a/modules/api/mw.echo.api.EchoApi.js b/modules/api/mw.echo.api.EchoApi.js index ad546173d..55436ac33 100644 --- a/modules/api/mw.echo.api.EchoApi.js +++ b/modules/api/mw.echo.api.EchoApi.js @@ -30,7 +30,7 @@ * @param {string} types An array of notification types to fetch: 'alert', 'message', 'all' * @param {string} [source="local"] The source from which to fetch the notifications * @param {boolean} [isForced] Force a refresh on the fetch notifications promise - * @return {[type]} Promise that is resolved with all notifications for the + * @return {jQuery.Promise} Promise that is resolved with all notifications for the * requested types. */ mw.echo.api.EchoApi.prototype.fetchNotifications = function ( type, source, isForced ) { @@ -80,8 +80,8 @@ /** * Mark all notifications for a given type as read in the given source. * - * @param {[type]} source Notifications source - * @param {[type]} type Notifications type + * @param {string} source Symbolic name of notifications source + * @param {string} type Notifications type * @return {jQuery.Promise} A promise that is resolved when the operation * is complete, with the number of unread notifications still remaining * for that type in the given source @@ -126,7 +126,7 @@ * * @param {string} source Notification source. * @param {string} type Notification type - * @return {Boolean} The API response for fetching notification has + * @return {boolean} The API response for fetching notification has * resolved in an error state, or is rejected. */ mw.echo.api.EchoApi.prototype.isFetchingErrorState = function ( source, type ) { diff --git a/modules/logger/mw.echo.Logger.js b/modules/logger/mw.echo.Logger.js index 84261cf24..a23872ab9 100644 --- a/modules/logger/mw.echo.Logger.js +++ b/modules/logger/mw.echo.Logger.js @@ -38,7 +38,7 @@ * is enabled * * @static - * @property {[type]} + * @property {boolean} */ mw.echo.Logger.static.clickThroughEnabled = OO.getProp( mw.config.get( 'wgEchoConfig' ),