wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-24 07:54:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Hygiene: Stop using id for footer

Browse source 
No need. Class works perfectly fine here.

Change-Id: I8188e759ad3eed971d5847b23d49b333d80b509f
This commit is contained in:
jdlrobson 2014-08-14 14:31:13 -07:00 committed by Jdlrobson
parent 178ec1b816
commit 965a8b8a2f
3 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
modules/overlay/ext.echo.overlay.js
View file

@ -223,8 +223,7 @@
_getFooterElement: function() { _getFooterElement: function() {
var $prefLink = $( '#pt-preferences a' ), var $prefLink = $( '#pt-preferences a' ),
$overlayFooter = $( '<div>' ) $overlayFooter = $( '<div class="mw-echo-overlay-footer">' );
.attr( 'id', 'mw-echo-overlay-footer' );
// add link to notifications archive // add link to notifications archive
$overlayFooter.append( $overlayFooter.append(

2
modules/overlay/ext.echo.overlay.less
View file

@ -155,7 +155,7 @@
} }
} }
#mw-echo-overlay-footer { .mw-echo-overlay-footer {
padding: 0; padding: 0;
border-top: 1px solid #DDDDDD; border-top: 1px solid #DDDDDD;
display: table; display: table;

2
tests/qunit/overlay/test_ext.echo.overlay.js
View file

@ -150,7 +150,7 @@
assert.strictEqual( $overlay.find( '.mw-echo-notifications' ).length, 1, 'Overlay contains a list of notifications.' ); assert.strictEqual( $overlay.find( '.mw-echo-notifications' ).length, 1, 'Overlay contains a list of notifications.' );
assert.strictEqual( $overlay.find( '.mw-echo-notifications li' ).length, 2, 'There are two notifications.' ); assert.strictEqual( $overlay.find( '.mw-echo-notifications li' ).length, 2, 'There are two notifications.' );
assert.strictEqual( $overlay.find( '.mw-echo-unread' ).length, 1, 'There is one unread notification.' ); assert.strictEqual( $overlay.find( '.mw-echo-unread' ).length, 1, 'There is one unread notification.' );
assert.strictEqual( $overlay.find( '#mw-echo-overlay-footer a' ).length, 2, assert.strictEqual( $overlay.find( '.mw-echo-overlay-footer a' ).length, 2,
'There is a footer with 2 links to preferences and all notifications.' ); 'There is a footer with 2 links to preferences and all notifications.' );
assert.strictEqual( this.$badge.text(), assert.strictEqual( this.$badge.text(),
'0', 'The alerts are marked as read once opened.' ); '0', 'The alerts are marked as read once opened.' );