From 1ec788babfad2f6e139f3e5c5c091186a16fb618 Mon Sep 17 00:00:00 2001 From: kaldari Date: Wed, 27 Mar 2013 17:17:35 -0700 Subject: [PATCH] Making agent param logic consistant It doesn't make sense to create 2 tokens for the i18n message in one case and only 1 token in another case. The current i18n messages are designed to handle only 1 token for agent (for both grammar and display). Change-Id: I7ab6b5a7b6731e60d0ea6e9e590c15039fdc4459 --- formatters/BasicFormatter.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/formatters/BasicFormatter.php b/formatters/BasicFormatter.php index 25de60b0a..7b7fb864e 100644 --- a/formatters/BasicFormatter.php +++ b/formatters/BasicFormatter.php @@ -327,9 +327,8 @@ class EchoBasicFormatter extends EchoNotificationFormatter { */ protected function processParam( $event, $param, $message, $user ) { if ( $param === 'agent' ) { - // Actually converts to two parameters for gender support if ( !$event->getAgent() ) { - $message->params( '', wfMessage( 'echo-no-agent' )->text() ); + $message->params( wfMessage( 'echo-no-agent' )->text() ); } else { $agent = $event->getAgent(); $message->params( $agent->getName() );