wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-24 07:54:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add missing @throws tag and change Exception subclass being thrown

Browse source 
Change-Id: I39e3cdbdf4bddc12ca2d7d6a2696b92b8b7cbd10
This commit is contained in:
Kunal Mehta 2015-12-14 10:41:54 -08:00
parent 7f44c242a0
commit 8ede0bf20d
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
includes/formatters/EventPresentationModel.php
View file

@ -132,6 +132,7 @@ abstract class EchoEventPresentationModel {
* @param bool $includeCurrent Include the current event (and its group)
* @param callable $groupCallback Callback that takes an EchoEvent and returns a grouping value
* @return int Number of bundled events or groups
* @throws InvalidArgumentException
*/
final protected function getBundleCount( $includeCurrent = true, $groupCallback = null ) {
$events = array_merge( $this->getBundledEvents(), array( $this->event ) );
@ -140,7 +141,7 @@ abstract class EchoEventPresentationModel {
// If we pass an invalid callback to array_map(), it'll just throw a warning
// and return NULL, so $count ends up being 0 or -1. Instead of doing that,
// throw an exception.
throw new MWException( 'Invalid callback passed to getBundleCount' );
throw new InvalidArgumentException( 'Invalid callback passed to getBundleCount' );
}
$events = array_unique( array_map( $groupCallback, $events ) );
}