wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-27 17:20:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid expensive array_shift where possible

Browse source 
array_shift manipulates the original array. This is surprisingly
expensive, because it iterates *all* elements in the array and
decrements numeric keys. The code touched in this patch does not need
this restructured new array, but only the individual elements.

Change-Id: I166fdbe199400611a21cbd608dd3e177336c8fd5
This commit is contained in:
Thiemo Kreuz 2018-12-17 11:46:02 +01:00
parent e8eb80eec3
commit 8d7fc8c66a
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
maintenance/testDiscussionParser.php
View file

@ -66,7 +66,7 @@ class TestDiscussionParser extends Maintenance {
$newData = unserialize( $newData );
$pageData = array_shift( $newData['query']['pages'] );
$pageData = reset( $newData['query']['pages'] );
$oldText = isset( $pageData['revisions'][1] )
? trim( $pageData['revisions'][1]['*'] ) . "\n"
: '';