From 8b396ec675c0497d1837bbed2d58605aad15b47c Mon Sep 17 00:00:00 2001 From: Catrope Date: Wed, 8 Mar 2017 01:20:43 +0000 Subject: [PATCH] Revert "Remove FloatableElement hack, no longer needed" We still need overflow-x set to a non-visible value, so that the overflow-y: visible rule doesn't take effect. If it does take effect, it breaks clipping. This reverts commit 97bde4d21a98562de79a2bd07079ba20d90e085d. Bug: T159888 Change-Id: Id834d9cf9615a8d2dad27faf2eb89743ad95da9d --- modules/styles/mw.echo.ui.NotificationBadgeWidget.less | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/styles/mw.echo.ui.NotificationBadgeWidget.less b/modules/styles/mw.echo.ui.NotificationBadgeWidget.less index d0bf01354..b2285a557 100644 --- a/modules/styles/mw.echo.ui.NotificationBadgeWidget.less +++ b/modules/styles/mw.echo.ui.NotificationBadgeWidget.less @@ -41,7 +41,9 @@ > .oo-ui-popupWidget-body { // Work around scrollbar rendering bug in Chrome overflow-y: visible; - // overflow-x can't be set to visible, otherwise ClippableElement breaks + // ...but make sure we don't actually overflow in the Y direction, + // to avoid breaking ClippableElement + overflow-x: auto; > .mw-echo-ui-notificationsListWidget > .mw-echo-ui-notificationItemWidget { // The popup body itself has a border. We need to override the notification