wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-12-12 07:55:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change function name to start with lowercase

Browse source 
Add ignore for the remaining phpcs issue

Enable the excluded sniff and suppress the issue inline
Avoid that new code gets added with this issue.

Change-Id: Ifae1c0979e224c33d1c59ebf2330bb27da0da2e5
This commit is contained in:
Umherirrender 2024-12-08 21:55:30 +01:00
parent 87af9edafa
commit 834ce601e5
3 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.phpcs.xml
View file

@ -5,7 +5,6 @@
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate" /> <exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPrivate" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" /> <exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" /> <exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
<exclude name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName" />
</rule> </rule>
<rule ref="MediaWiki.Files.ClassMatchesFilename.NotMatch"> <rule ref="MediaWiki.Files.ClassMatchesFilename.NotMatch">
<exclude-pattern>includes/</exclude-pattern> <exclude-pattern>includes/</exclude-pattern>

2
includes/Hooks.php
View file

@ -84,6 +84,8 @@ use SkinTemplate;
use Wikimedia\Stats\StatsFactory; use Wikimedia\Stats\StatsFactory;
use WikiPage; use WikiPage;
// phpcs:disable MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName
class Hooks implements class Hooks implements
AbortTalkPageEmailNotificationHook, AbortTalkPageEmailNotificationHook,
ApiMain__moduleManagerHook, ApiMain__moduleManagerHook,

4
tests/phpunit/Controller/NotificationControllerTest.php
View file

@ -356,7 +356,7 @@ class NotificationControllerTest extends MediaWikiIntegrationTestCase {
} }
/** /**
* @dataProvider PageLinkedTitleMutedByUserDataProvider * @dataProvider pageLinkedTitleMutedByUserDataProvider
* @param int $mockArticleID * @param int $mockArticleID
* @param int[] $mockMutedTitlePreferences * @param int[] $mockMutedTitlePreferences
* @param bool $expected * @param bool $expected
@ -375,7 +375,7 @@ class NotificationControllerTest extends MediaWikiIntegrationTestCase {
); );
} }
public static function PageLinkedTitleMutedByUserDataProvider(): array { public static function pageLinkedTitleMutedByUserDataProvider(): array {
return [ return [
[ [
123, 123,