wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-27 17:20:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix logging of cross-wiki API errors

Browse source 
Error messages included a non-existent 'code' parameter; use the
curl error message instead. Also log the error status (which is
there somewhere in 'response' but logstash doesn't manipulate JSON
fields well).

Bug: T328128
Change-Id: If295d7a3b397b22301986a226a54df908c2ccf4d
This commit is contained in:
Gergő Tisza 2023-03-19 16:48:10 -07:00
parent 5f373567c5
commit 79ee292ca4
No known key found for this signature in database
GPG key ID: C34FEC97E6257F96
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/ForeignWikiRequest.php
View file

@ -245,9 +245,11 @@ class EchoForeignWikiRequest {
if ( !isset( $results[$wiki] ) ) { if ( !isset( $results[$wiki] ) ) {
LoggerFactory::getInstance( 'Echo' )->warning( LoggerFactory::getInstance( 'Echo' )->warning(
'Failed to fetch API response from {wiki}. Error code {code}', 'Failed to fetch API response from {wiki}. Error: {error}',
[ [
'wiki' => $wiki, 'wiki' => $wiki,
'error' => $response['response']['error'] ?? 'unknown',
'statusCode' => $statusCode,
'response' => $response['response'], 'response' => $response['response'],
'request' => $reqs[$wiki], 'request' => $reqs[$wiki],
] ]