From 78dc653c800d6cd6f7d26263c87566acb255e45c Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Sun, 7 Jun 2015 18:30:49 -0700 Subject: [PATCH] Remove dead dismiss code mw.echo.setUpDismissability was removed in 08fc83b6de1feb5823, and will never be called since the class is never set. Change-Id: I1e13bbabaeb7df21c161d4cf4205a1564e1d81d9 --- modules/overlay/ext.echo.overlay.js | 6 ------ modules/special/ext.echo.special.js | 7 ------- 2 files changed, 13 deletions(-) diff --git a/modules/overlay/ext.echo.overlay.js b/modules/overlay/ext.echo.overlay.js index 76de9a513..0dadd587b 100644 --- a/modules/overlay/ext.echo.overlay.js +++ b/modules/overlay/ext.echo.overlay.js @@ -191,12 +191,6 @@ $li.wrapInner( $wrapper ); mw.echo.setupNotificationLogging( $li, 'flyout' ); - - // Set up each individual notification with a close box and dismiss - // interface if it is dismissable. - if ( $li.find( '.mw-echo-dismiss' ).length ) { - mw.echo.setUpDismissability( $li ); - } } ); if ( !this.markOnView && this.unread.length ) { diff --git a/modules/special/ext.echo.special.js b/modules/special/ext.echo.special.js index 74c4502b2..dba9203bc 100644 --- a/modules/special/ext.echo.special.js +++ b/modules/special/ext.echo.special.js @@ -32,9 +32,6 @@ // box and dismiss interface if it is dismissable. $( '.mw-echo-notification' ).each( function () { mw.echo.setupNotificationLogging( $( this ), 'archive' ); - if ( $( this ).find( '.mw-echo-dismiss' ).length ) { - mw.echo.setUpDismissability( this ); - } } ); $( '#mw-echo-moreinfo-link' ).click( function () { @@ -108,10 +105,6 @@ } mw.echo.setupNotificationLogging( $li, 'archive' ); - - if ( $li.find( '.mw-echo-dismiss' ).length ) { - mw.echo.setUpDismissability( $li ); - } } ); that.notcontinue = notifications['continue'];