wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-27 17:20:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "(bug 46046) Notification should not be created for anon users"

Browse source
This commit is contained in:
Kaldari 2013-03-15 00:33:49 +00:00 committed by Gerrit Code Review
parent 872464a965 ded706dd73
commit 6e8aa9b808
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
controller/NotificationController.php
View file

@ -204,6 +204,12 @@ class EchoNotificationController {
foreach ( $subscriptions as $subscription ) {
$user = $subscription->getUser();
// Notification should not be sent to anonymous user
if ( $user->isAnon() ) {
continue;
}
$notifyTypes = $subscription->getNotificationTypes();
$notifyTypes = array_keys( array_filter( $notifyTypes ) );

3
includes/DiscussionParser.php
View file

@ -112,8 +112,9 @@ abstract class EchoDiscussionParser {
// 1. the user name is not valid
// 2. the user mentions themselves
// 3. the user is the owner of the talk page
// 4. user is anonymous
if (
!$user || $user->getId() == $revision->getUser() ||
!$user || $user->isAnon() || $user->getId() == $revision->getUser() ||
( $title->getNamespace() === NS_USER_TALK && $title->getDBkey() === $dbk )
) {
continue;