wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-28 09:40:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Make DEFAULT_SECTION a constant"

Browse source
This commit is contained in:
jenkins-bot 2021-08-23 20:45:01 +00:00 committed by Gerrit Code Review
parent aaf8d8a98c 6cd82d25a7
commit 6d55b5a0bd
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
includes/AttributeManager.php
View file

@ -45,7 +45,7 @@ class EchoAttributeManager {
public const ALL = 'all';
/** @var string */
protected static $DEFAULT_SECTION = self::ALERT;
protected const DEFAULT_SECTION = self::ALERT;
/**
* Notifications are broken down to two sections, default is alert
@ -174,7 +174,7 @@ class EchoAttributeManager {
public function getEventsForSection( $section ) {
$events = [];
$isDefault = ( $section === self::$DEFAULT_SECTION );
$isDefault = ( $section === self::DEFAULT_SECTION );
foreach ( $this->notifications as $event => $attribs ) {
if (
@ -372,7 +372,7 @@ class EchoAttributeManager {
* @return string
*/
public function getNotificationSection( $notificationType ) {
return $this->notifications[$notificationType]['section'] ?? self::$DEFAULT_SECTION;
return $this->notifications[$notificationType]['section'] ?? self::DEFAULT_SECTION;
}
/**