wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-27 17:20:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "hooks: remove use of IBufferingStatsdDataFactory"

Browse source
This commit is contained in:
jenkins-bot 2024-05-27 11:49:47 +00:00 committed by Gerrit Code Review
parent b721cc23df b29a6ae0e5
commit 63736536f5
1 changed files with 6 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
includes/Hooks.php
View file

@ -9,7 +9,6 @@ use EchoUserLocator;
use EmailNotification;
use ExtensionRegistry;
use HTMLCheckMatrix;
use IBufferingStatsdDataFactory;
use Language;
use LogEntry;
use LogicException;
@ -124,11 +123,7 @@ class Hooks implements
private NamespaceInfo $namespaceInfo;
private PermissionManager $permissionManager;
private RevisionStore $revisionStore;
/**
* @var IBufferingStatsdDataFactory|StatsFactory|null
*/
private $statsFactory;
private StatsFactory $statsFactory;
private TalkPageNotificationManager $talkPageNotificationManager;
private UserEditTracker $userEditTracker;
private UserFactory $userFactory;
@ -147,7 +142,7 @@ class Hooks implements
NamespaceInfo $namespaceInfo,
PermissionManager $permissionManager,
RevisionStore $revisionStore,
$statsFactory,
StatsFactory $statsFactory,
TalkPageNotificationManager $talkPageNotificationManager,
UserEditTracker $userEditTracker,
UserFactory $userFactory,
@ -163,7 +158,7 @@ class Hooks implements
$this->namespaceInfo = $namespaceInfo;
$this->permissionManager = $permissionManager;
$this->revisionStore = $revisionStore;
$this->statsFactory = $statsFactory;
$this->statsFactory = $statsFactory->withComponent( 'Echo' );
$this->talkPageNotificationManager = $talkPageNotificationManager;
$this->userEditTracker = $userEditTracker;
$this->userFactory = $userFactory;
@ -1131,15 +1126,9 @@ class Hooks implements
// Record that the user is going to see an indicator that they have unseen notifications
// This is part of tracking how likely users are to click a badge with unseen notifications.
// The other part is the 'echo.unseen.click' counter, see ext.echo.init.js.
if ( $this->statsFactory instanceof IBufferingStatsdDataFactory ) {
$this->statsFactory->increment( 'echo.unseen' );
}
if ( $this->statsFactory instanceof StatsFactory ) {
$this->statsFactory->withComponent( 'Echo' )->getCounter( 'unseen_total' )
->copyToStatsdAt( 'echo.unseen' )
->increment();
}
$this->statsFactory->getCounter( 'unseen_total' )
->copyToStatsdAt( 'echo.unseen' )
->increment();
}
}