wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-30 18:45:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move skinStyle rules to skin

Browse source 
Badge rendering is a responsibility of the skin (since badges
must work with JavaScript disabled). Because of this, we move the
styles to their associated skin (Monobook and Minerva)

Bug: T257143
Depends-On: I1999185d19e171900f2da5acbd39125013d3582c
Depends-On: Ib148e90a3fde42ebcf271432dce3ccfc8985c677
Change-Id: I9319c72183a312cf0f55942ba1f78aa974ce5e84
This commit is contained in:
Jon Robson 2022-11-18 16:10:54 -08:00
parent bd0f5fda49
commit 499684815b
3 changed files with 0 additions and 46 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
extension.json
View file

@ -370,14 +370,6 @@
"styles": [ "styles": [
"nojs/mw.echo.badge.less" "nojs/mw.echo.badge.less"
], ],
"skinStyles": {
"minerva": [
"nojs/mw.echo.badge.minerva.less"
],
"monobook": [
"nojs/mw.echo.badge.monobook.less"
]
},
"targets": [ "targets": [
"desktop", "desktop",
"mobile" "mobile"

24
modules/nojs/mw.echo.badge.minerva.less
View file

@ -1,24 +0,0 @@
#pt-notifications-alert {
.mw-echo-notifications-badge-dimmed,
.mw-echo-notifications-badge {
top: 0;
margin: 0;
}
a.mw-ui-icon-wikimedia-bellOutline-base20 {
color: transparent;
}
}
#pt-notifications-alert.oo-ui-widget {
list-style: none;
width: 1.25em;
height: 1.25em;
padding: 0.75em;
vertical-align: middle;
a {
height: auto;
padding: 0;
}
}

14
modules/nojs/mw.echo.badge.monobook.less
View file

@ -1,14 +0,0 @@
@import '../echo.variables.less';
#pt-notifications-notice .mw-echo-notifications-badge,
#pt-notifications-alert .mw-echo-notifications-badge {
display: inline-block;
background-size: 16px 16px;
background-repeat: no-repeat;
top: -1px;
&:after {
top: 6px;
left: 45%;
}
}