From 499684815b1e7f730aad65ebfe22e7c2af7026af Mon Sep 17 00:00:00 2001
From: Jon Robson <jdlrobson@gmail.com>
Date: Fri, 18 Nov 2022 16:10:54 -0800
Subject: [PATCH] Move skinStyle rules to skin

Badge rendering is a responsibility of the skin (since badges
must work with JavaScript disabled). Because of this, we move the
styles to their associated skin (Monobook and Minerva)

Bug: T257143
Depends-On: I1999185d19e171900f2da5acbd39125013d3582c
Depends-On: Ib148e90a3fde42ebcf271432dce3ccfc8985c677
Change-Id: I9319c72183a312cf0f55942ba1f78aa974ce5e84
---
 extension.json                           |  8 --------
 modules/nojs/mw.echo.badge.minerva.less  | 24 ------------------------
 modules/nojs/mw.echo.badge.monobook.less | 14 --------------
 3 files changed, 46 deletions(-)
 delete mode 100644 modules/nojs/mw.echo.badge.minerva.less
 delete mode 100644 modules/nojs/mw.echo.badge.monobook.less

diff --git a/extension.json b/extension.json
index 437cb4337..dd74b0529 100644
--- a/extension.json
+++ b/extension.json
@@ -370,14 +370,6 @@
 			"styles": [
 				"nojs/mw.echo.badge.less"
 			],
-			"skinStyles": {
-				"minerva": [
-					"nojs/mw.echo.badge.minerva.less"
-				],
-				"monobook": [
-					"nojs/mw.echo.badge.monobook.less"
-				]
-			},
 			"targets": [
 				"desktop",
 				"mobile"
diff --git a/modules/nojs/mw.echo.badge.minerva.less b/modules/nojs/mw.echo.badge.minerva.less
deleted file mode 100644
index 47cb2c90d..000000000
--- a/modules/nojs/mw.echo.badge.minerva.less
+++ /dev/null
@@ -1,24 +0,0 @@
-#pt-notifications-alert {
-	.mw-echo-notifications-badge-dimmed,
-	.mw-echo-notifications-badge {
-		top: 0;
-		margin: 0;
-	}
-
-	a.mw-ui-icon-wikimedia-bellOutline-base20 {
-		color: transparent;
-	}
-}
-
-#pt-notifications-alert.oo-ui-widget {
-	list-style: none;
-	width: 1.25em;
-	height: 1.25em;
-	padding: 0.75em;
-	vertical-align: middle;
-
-	a {
-		height: auto;
-		padding: 0;
-	}
-}
diff --git a/modules/nojs/mw.echo.badge.monobook.less b/modules/nojs/mw.echo.badge.monobook.less
deleted file mode 100644
index 93eec98e1..000000000
--- a/modules/nojs/mw.echo.badge.monobook.less
+++ /dev/null
@@ -1,14 +0,0 @@
-@import '../echo.variables.less';
-
-#pt-notifications-notice .mw-echo-notifications-badge,
-#pt-notifications-alert .mw-echo-notifications-badge {
-	display: inline-block;
-	background-size: 16px 16px;
-	background-repeat: no-repeat;
-	top: -1px;
-
-	&:after {
-		top: 6px;
-		left: 45%;
-	}
-}