wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-24 16:04:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Limit Echo mentions to 20 users

Browse source 
Bug: 50082
Change-Id: I7eb0f41fc9b0e3a396383a1adaecf51dc883217f
This commit is contained in:
Erik Bernhardson 2014-09-11 11:14:17 -07:00 committed by EBernhardson
parent f4ef97cb06
commit 44ec374632
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
includes/DiscussionParser.php
View file

@ -174,9 +174,10 @@ abstract class EchoDiscussionParser {
} }
$mentionedUsers[$user->getId()] = $user->getId(); $mentionedUsers[$user->getId()] = $user->getId();
$count++; $count++;
// This is an unbounded list, put a cap on the allowable mentioned user list // If more than 20 users are being pinged this is likely a spam/attack vector
if ( $count > 100 ) { // Don't send any mention notifications.
break; if ( $count > 20 ) {
return;
} }
} }