wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-23 23:44:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Moving dependencies from ext.echo.base to more specific modules

Browse source 
mediawiki.api and mediawiki.Uri are desktop-only modules that are
not actually needed by ext.echo.base. Moving the dependency
declarations to more specific modules so that ext.echo.base is
usable by mobile notifications. ResourceLoader is smart enough to
not double-load them, so there should be no performance difference.

Also removing unused 'cancel' message.

Change-Id: I9fa8c4501e038ded9125c3b43e5207c355af2db9
This commit is contained in:
kaldari 2013-09-25 10:52:58 -07:00 committed by Kaldari
parent 08fc83b6de
commit 4380e81afe
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Echo.php
View file

@ -141,15 +141,12 @@ $echoResourceTemplate = array(
);
$wgResourceModules += array(
// ext.echo.base is used by mobile notifications as well, so be sure not to add any
// dependencies that do not target mobile.
'ext.echo.base' => $echoResourceTemplate + array(
'styles' => 'base/ext.echo.base.css',
'scripts' => 'base/ext.echo.base.js',
'dependencies' => array(
'mediawiki.api',
'mediawiki.Uri',
),
'messages' => array(
'cancel',
'echo-error-preference',
'echo-error-token',
),
@ -166,6 +163,8 @@ $wgResourceModules += array(
),
'dependencies' => array(
'ext.echo.base',
'mediawiki.api',
'mediawiki.Uri',
'mediawiki.util',
'mediawiki.jqueryMsg',
'mediawiki.user',
@ -187,6 +186,8 @@ $wgResourceModules += array(
'styles' => 'special/ext.echo.special.css',
'dependencies' => array(
'ext.echo.base',
'mediawiki.api',
'mediawiki.Uri',
'mediawiki.ui',
'mediawiki.jqueryMsg',
'mediawiki.user',