wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-27 17:20:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant check

Browse source 
$wgEchoNotifications is checked inside EchoEvent::create(). Similar
code (e.g. onRollbackComplete() in this file) does not check it.

Change-Id: I2be05ae182c3fd5d90b87e9579f8c2aa6b79c655
This commit is contained in:
Bartosz Dziewoński 2021-03-17 12:50:45 +01:00
parent 906146ac79
commit 43747e5b0b
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
includes/EchoHooks.php
View file

@ -527,8 +527,6 @@ class EchoHooks implements RecentChange_saveHook {
RevisionRecord $revisionRecord,
EditResult $editResult
) {
global $wgEchoNotifications;
if ( $editResult->isNullEdit() ) {
return;
}
@ -587,7 +585,7 @@ class EchoHooks implements RecentChange_saveHook {
// Handle the case of someone undoing an edit, either through the
// 'undo' link in the article history or via the API.
if ( isset( $wgEchoNotifications['reverted'] ) && $undidRevId ) {
if ( $undidRevId ) {
$store = MediaWikiServices::getInstance()->getRevisionStore();
$undidRevision = $store->getRevisionById( $undidRevId );
if (