wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-27 17:20:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't put a whole User object in extra[mentioned-users]

Browse source 
DiscussionParser::getUserMentions() returns mentions in an array of the
form [ID => ID]. UserLocator says "we shouldn't receive User instances,
but allow it for backward compatability". But
DiscussionParser::generateEventsForRevision() was putting User objects
into the extra when there is a mention in the edit summary.

I noticed this when I accidentally made User objects be unserializable
in a core patch.

So, I made generateEventsForRevision() generate mention arrays in the
same ID=>ID format as getUserMentions().

Change-Id: I7c6d25950c8887b50426863c7b0a2d5d007559dd
This commit is contained in:
Tim Starling 2020-05-05 14:31:24 +10:00
parent 4b6c8fe025
commit 41d53fde50
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/DiscussionParser.php
View file

@ -124,7 +124,7 @@ abstract class EchoDiscussionParser {
if ( $count >= $wgEchoMaxMentionsInEditSummary ) {
break;
}
$mentionedUsers[] = $summaryUser;
$mentionedUsers[$summaryUser->getId()] = $summaryUser->getId();
$count++;
}