wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-24 07:54:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

(bug 43701) - LinkedPage was linked by 127.0.0.1 from page

Browse source 
If multiple pages are transcluding a page, a link update on the page being transcluded would trigger notifications for all the transcluding pages, we only need to fire the notification for the page being transcluded.

The solution in this patch seems to work but I have not fully investigated all possible scenarios. -2 for now

Change-Id: I6932ffb2e5dba3da40db17bd37ce2cc6cb8aee17
This commit is contained in:
bsitu 2013-01-08 15:57:28 -08:00
parent bc45a664d2
commit 39416e503d
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Hooks.php
View file

@ -363,19 +363,26 @@ class EchoHooks {
* @return bool
*/
public static function onLinksUpdateAfterInsert( $linksUpdate, $table, $insertions ) {
// Confirm: if $linksUpdate->mRecursive is false, that means $linkUpdate->mTitle is
// transcluding other page, and this link update is resulting from the other page
// link update
if ( !$linksUpdate->mRecursive ) {
return true;
}
// Handle only inserts to pagelinks table for content namespace pages
if ( $table !== 'pagelinks' || !MWNamespace::isContent( $linksUpdate->mTitle->getNamespace() ) ) {
return true;
}
// only create notifications for links to content namespace pages
// Only create notifications for links to content namespace pages
foreach ( $insertions as $key => $page ) {
if ( !MWNamespace::isContent( $page['pl_namespace'] ) ) {
unset( $insertions[$key] );
}
}
// exits if there is no new link
// Exits if there is no new link
if ( !$insertions ) {
return true;
}