wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-12-01 02:46:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid flashes: late debounce causes annoying flashes

Browse source 
Validate elements are updated before replacing elements in the DOM.

Bug: T112168
Change-Id: Ia9556b0b9e9f5b0132be5a61a2cde7bb4dc5606e
This commit is contained in:
eranroz 2015-09-11 13:36:13 +03:00 committed by Esanders
parent 6bece9bf06
commit 381b7be7d8
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
modules/ext.echo.init.js
View file

@ -34,6 +34,8 @@
badgeIcon: 'speechBubble',
links: links
} );
// avoid late debouncedUpdateThemeClasses
mw.echo.ui.messageWidget.debouncedUpdateThemeClasses();
$existingMessageLink.replaceWith( mw.echo.ui.messageWidget.$element );
}
@ -48,6 +50,9 @@
},
links: links
} );
// avoid late debouncedUpdateThemeClasses
mw.echo.ui.alertWidget.debouncedUpdateThemeClasses();
$existingAlertLink.replaceWith( mw.echo.ui.alertWidget.$element );
} );