From 36af0f2cf18c2c999ea81ffe2ac44ce487280492 Mon Sep 17 00:00:00 2001
From: Max Semenik <maxsem.wiki@gmail.com>
Date: Mon, 18 Nov 2019 19:52:30 -0800
Subject: [PATCH] Stop passing objects by reference

Bug: T193950
Change-Id: Ie8a2302137c5b5fc67862031ffe244c50769fa1f
---
 includes/EchoHooks.php | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/includes/EchoHooks.php b/includes/EchoHooks.php
index a04b97471..c51fa386b 100644
--- a/includes/EchoHooks.php
+++ b/includes/EchoHooks.php
@@ -137,9 +137,9 @@ class EchoHooks {
 
 	/**
 	 * Handler for ResourceLoaderRegisterModules hook
-	 * @param ResourceLoader &$resourceLoader
+	 * @param ResourceLoader $resourceLoader
 	 */
-	public static function onResourceLoaderRegisterModules( ResourceLoader &$resourceLoader ) {
+	public static function onResourceLoaderRegisterModules( ResourceLoader $resourceLoader ) {
 		global $wgExtensionDirectory, $wgEchoNotificationIcons, $wgEchoSecondaryIcons;
 		$resourceLoader->register( 'ext.echo.emailicons', [
 			'class' => 'ResourceLoaderEchoImageModule',
@@ -495,7 +495,7 @@ class EchoHooks {
 	 * @see https://www.mediawiki.org/wiki/Manual:Hooks/PageContentSaveComplete
 	 *
 	 * @param WikiPage $wikiPage modified WikiPage
-	 * @param User &$user User who edited
+	 * @param User $user User who edited
 	 * @param Content $content New article text
 	 * @param string $summary Edit summary
 	 * @param bool $minoredit Minor edit or not
@@ -503,7 +503,7 @@ class EchoHooks {
 	 * @param string $sectionanchor Section that was edited
 	 * @param int &$flags Edit flags
 	 * @param Revision $revision Revision that was created
-	 * @param Status &$status
+	 * @param Status $status
 	 * @param int $baseRevId
 	 * @param int $undidRevId
 	 *
@@ -511,7 +511,7 @@ class EchoHooks {
 	 */
 	public static function onPageContentSaveComplete(
 		WikiPage $wikiPage,
-		&$user,
+		$user,
 		$content,
 		$summary,
 		$minoredit,
@@ -519,7 +519,7 @@ class EchoHooks {
 		$sectionanchor,
 		&$flags,
 		$revision,
-		&$status,
+		Status $status,
 		$baseRevId,
 		$undidRevId = 0
 	) {