Restore old Echo styling through several reverts

These dont work. Timeless provides its own skinStyles for this module:
* Revert "Timeless skinStyles should be additive not replace"
This reverts commit 98d0d296a8.
* Revert "Use skinStyles for deciding where the text-indent should apply"
This reverts commit 8adab78547.

A new implementation in Vector means these are redundant:
*  Revert "Item label can now use overflow hidden"
This reverts commit b5dd7baa08.
* Revert "Drop text indent in modern Vector"
This reverts commit 150fc7a16c.

Bug: T264339
Depends-On: I2afc12504d7184583fa8331479125474c68017dc
Change-Id: Ifd0dd5a0479588664b772fb839dbbcd8d7c47320

extension.json

@@ -347,9 +347,6 @@
 				"nojs/mw.echo.badge.less"
 			],
 			"skinStyles": {
-				"+timeless": [
-					"nojs/mw.echo.badge.timeless.less"
-				],
 				"minerva": [
 					"nojs/mw.echo.badge.minerva.less"
 				],

includes/EchoHooks.php

@@ -1103,7 +1103,6 @@ class EchoHooks implements RecentChange_saveHook {
 			'text' => $alertText,
 			'active' => ( $url == $title->getLocalURL() ),
 			'class' => $alertLinkClasses,
-			'text-wrapper' => 'span',
 			'data' => [
 				'counter-num' => $alertCount,
 				'counter-text' => $alertFormattedCount,
@@ -1119,7 +1118,6 @@ class EchoHooks implements RecentChange_saveHook {
 			'text' => $msgText,
 			'active' => ( $url == $title->getLocalURL() ),
 			'class' => $msgLinkClasses,
-			'text-wrapper' => 'span',
 			'data' => [
 				'counter-num' => $msgCount,
 				'counter-text' => $msgFormattedCount,

modules/nojs/mw.echo.badge.less

@@ -11,9 +11,10 @@
 		width: 20px;
 		height: 20px;
 		margin: 0 2px;
-		background-repeat: no-repeat;
-		background-position: center center;
+		// Hide the text, but keep accessible for screen-readers
+		// Later we put the counter back onscreen with a zero text-indent
 		top: -5px;
+		text-indent: -9999px;
 		border-radius: @border-radius-base;
 		cursor: pointer;
 		text-decoration: none;
@@ -75,12 +76,6 @@
 				visibility: hidden;
 			}
 		}
-
-		span {
-			overflow: hidden;
-			width: 100%;
-			display: inline-block;
-		}
 	}
 
 	&.oo-ui-flaggedElement-unseen,
@@ -94,11 +89,4 @@
 		}
 	}
 }
-
-/* vector */
-.skin-vector-legacy .mw-echo-notifications-badge {
-	// Hide the text, but keep accessible for screen-readers
-	// Later we put the counter back onscreen with a zero text-indent
-	text-indent: -9999px;
-}
 /* stylelint-enable no-descending-specificity */

modules/nojs/mw.echo.badge.monobook.less

@@ -6,7 +6,6 @@
 	background-size: 16px 16px;
 	background-repeat: no-repeat;
 	top: -1px;
-	text-indent: -9999px;
 
 	&:after {
 		top: 6px;

modules/nojs/mw.echo.badge.timeless.less

@@ -1,3 +0,0 @@
-.mw-echo-notifications-badge {
-	text-indent: -9999px;
-}