From 2c3d370846d336e7cdcc030f30846db997c412f3 Mon Sep 17 00:00:00 2001
From: libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>
Date: Sat, 23 Oct 2021 21:59:04 +0000
Subject: [PATCH] build: Updating mediawiki/mediawiki-codesniffer to 38.0.0

Change-Id: I10e9f9f6ddd9539ff95636902219c0e9fa35fc0f
---
 composer.json                               | 2 +-
 tests/phpunit/NotificationsTest.php         | 2 +-
 tests/phpunit/unit/AttributeManagerTest.php | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/composer.json b/composer.json
index eff977429..f8c4c3d69 100644
--- a/composer.json
+++ b/composer.json
@@ -1,6 +1,6 @@
 {
 	"require-dev": {
-		"mediawiki/mediawiki-codesniffer": "37.0.0",
+		"mediawiki/mediawiki-codesniffer": "38.0.0",
 		"mediawiki/mediawiki-phan-config": "0.11.0",
 		"mediawiki/minus-x": "1.1.1",
 		"php-parallel-lint/php-console-highlighter": "0.5.0",
diff --git a/tests/phpunit/NotificationsTest.php b/tests/phpunit/NotificationsTest.php
index 95c81b023..05ac8ac22 100644
--- a/tests/phpunit/NotificationsTest.php
+++ b/tests/phpunit/NotificationsTest.php
@@ -44,7 +44,7 @@ class NotificationsTest extends MediaWikiIntegrationTestCase {
 		$ur->setContext( $context );
 		$ur->doSaveUserGroups( $user, [ 'sysop' ], [], 'reason' );
 		$event = self::getLatestNotification( $user );
-		$this->assertEquals( $event->getType(), 'user-rights' );
+		$this->assertEquals( 'user-rights', $event->getType() );
 		$this->assertEquals( $this->sysop->getName(), $event->getAgent()->getName() );
 		$extra = $event->getExtra();
 		$this->assertArrayHasKey( 'add', $extra );
diff --git a/tests/phpunit/unit/AttributeManagerTest.php b/tests/phpunit/unit/AttributeManagerTest.php
index b04bbdf0f..f77447117 100644
--- a/tests/phpunit/unit/AttributeManagerTest.php
+++ b/tests/phpunit/unit/AttributeManagerTest.php
@@ -131,10 +131,10 @@ class EchoAttributeManagerTest extends MediaWikiUnitTestCase {
 			]
 		];
 		$manager = $this->getAttributeManager( $notif, $category );
-		$this->assertEquals( $manager->getNotificationCategory( 'event_one' ), 'category_one' );
+		$this->assertEquals( 'category_one', $manager->getNotificationCategory( 'event_one' ) );
 
 		$manager = $this->getAttributeManager( $notif );
-		$this->assertEquals( $manager->getNotificationCategory( 'event_one' ), 'other' );
+		$this->assertEquals( 'other', $manager->getNotificationCategory( 'event_one' ) );
 
 		$notif = [
 			'event_one' => [
@@ -147,7 +147,7 @@ class EchoAttributeManagerTest extends MediaWikiUnitTestCase {
 			]
 		];
 		$manager = $this->getAttributeManager( $notif, $category );
-		$this->assertEquals( $manager->getNotificationCategory( 'event_one' ), 'other' );
+		$this->assertEquals( 'other', $manager->getNotificationCategory( 'event_one' ) );
 	}
 
 	public function testGetCategoryPriority() {