Remove obsolete PHPDoc copies from fully typed constructors

It's all in the code now. These comments don't add anything any
more.

Change-Id: I66a3723c4fe9ccce989f5b533390d5ce928dc195

includes/ArrayList.php

@@ -13,9 +13,6 @@ class ArrayList implements ContainmentList {
 	 */
 	protected $list;
 
-	/**
-	 * @param array $list
-	 */
 	public function __construct( array $list ) {
 		$this->list = $list;
 	}

includes/Cache/RevisionLocalCache.php

@@ -13,10 +13,6 @@ class RevisionLocalCache extends LocalCache {
 	private IConnectionProvider $dbProvider;
 	private RevisionStore $revisionStore;
 
-	/**
-	 * @param IConnectionProvider $dbProvider
-	 * @param RevisionStore $revisionStore
-	 */
 	public function __construct(
 		IConnectionProvider $dbProvider,
 		RevisionStore $revisionStore

includes/Cache/TitleLocalCache.php

@@ -15,10 +15,6 @@ class TitleLocalCache extends LocalCache {
 	private PageStore $pageStore;
 	private TitleFactory $titleFactory;
 
-	/**
-	 * @param PageStore $pageStore
-	 * @param TitleFactory $titleFactory
-	 */
 	public function __construct(
 		PageStore $pageStore,
 		TitleFactory $titleFactory

includes/ContainmentSet.php

@@ -34,9 +34,6 @@ class ContainmentSet {
 	 */
 	protected $recipient;
 
-	/**
-	 * @param User $recipient
-	 */
 	public function __construct( User $recipient ) {
 		$this->recipient = $recipient;
 	}

includes/EmailBatch.php

@@ -58,11 +58,6 @@ class EmailBatch {
 	 */
 	protected static $displaySize = 20;
 
-	/**
-	 * @param User $user
-	 * @param UserOptionsManager $userOptionsManager
-	 * @param LanguageFactory $languageFactory
-	 */
 	public function __construct(
 		User $user,
 		UserOptionsManager $userOptionsManager,

includes/Formatters/EchoPresentationModelSection.php

@@ -41,11 +41,6 @@ class EchoPresentationModelSection {
 	 */
 	protected $language;
 
-	/**
-	 * @param Event $event
-	 * @param User $user
-	 * @param Language $language
-	 */
 	public function __construct( Event $event, User $user, Language $language ) {
 		$this->event = $event;
 		$this->user = $user;

includes/Gateway/UserNotificationGateway.php

@@ -43,11 +43,6 @@ class UserNotificationGateway {
 	 */
 	private $config;
 
-	/**
-	 * @param UserIdentity $user
-	 * @param DbFactory $dbFactory
-	 * @param Config $config
-	 */
 	public function __construct( UserIdentity $user, DbFactory $dbFactory, Config $config ) {
 		$this->user = $user;
 		$this->dbFactory = $dbFactory;

includes/Jobs/NotificationDeleteJob.php

@@ -23,11 +23,6 @@ use MediaWiki\User\User;
 class NotificationDeleteJob extends Job {
 	private JobQueueGroup $jobQueueGroup;
 
-	/**
-	 * @param Title $title
-	 * @param array $params
-	 * @param JobQueueGroup $jobQueueGroup
-	 */
 	public function __construct(
 		Title $title,
 		array $params,

includes/Mapper/AbstractMapper.php

@@ -22,9 +22,6 @@ abstract class AbstractMapper {
 	 */
 	protected $listeners;
 
-	/**
-	 * @param DbFactory|null $dbFactory
-	 */
 	public function __construct( DbFactory $dbFactory = null ) {
 		$this->dbFactory = $dbFactory ?? DbFactory::newFromDefault();
 	}

includes/NotifUser.php

@@ -100,14 +100,6 @@ class NotifUser {
 	/**
 	 * Usually client code doesn't need to initialize the object directly
 	 * because it could be obtained from factory method newFromUser()
-	 * @param UserIdentity $user
-	 * @param WANObjectCache $cache
-	 * @param UserNotificationGateway $userNotifGateway
-	 * @param NotificationMapper $notifMapper
-	 * @param TargetPageMapper $targetPageMapper
-	 * @param UserOptionsLookup $userOptionsLookup
-	 * @param UserFactory $userFactory
-	 * @param ReadOnlyMode $readOnlyMode
 	 */
 	public function __construct(
 		UserIdentity $user,

includes/Push/Api/ApiEchoPushSubscriptionsCreate.php

@@ -37,11 +37,6 @@ class ApiEchoPushSubscriptionsCreate extends ApiBase {
 		return $module;
 	}
 
-	/**
-	 * @param ApiMain $mainModule
-	 * @param string $moduleName
-	 * @param SubscriptionManager $subscriptionManager
-	 */
 	public function __construct(
 		ApiMain $mainModule,
 		string $moduleName,

includes/Push/Api/ApiEchoPushSubscriptionsDelete.php

@@ -31,11 +31,6 @@ class ApiEchoPushSubscriptionsDelete extends ApiBase {
 		return $module;
 	}
 
-	/**
-	 * @param ApiMain $mainModule
-	 * @param string $moduleName
-	 * @param SubscriptionManager $subscriptionManager
-	 */
 	public function __construct(
 		ApiMain $mainModule,
 		string $moduleName,

includes/Push/Subscription.php

@@ -32,12 +32,6 @@ class Subscription {
 		);
 	}
 
-	/**
-	 * @param string $provider
-	 * @param string $token
-	 * @param string|null $topic
-	 * @param ConvertibleTimestamp $updated
-	 */
 	public function __construct( string $provider, string $token, ?string $topic, ConvertibleTimestamp $updated ) {
 		$this->provider = $provider;
 		$this->token = $token;

includes/Services.php

@@ -13,45 +13,34 @@ class Services {
 	/** @var MediaWikiServices */
 	private $services;
 
-	/** @return Services */
 	public static function getInstance(): Services {
 		return new self( MediaWikiServices::getInstance() );
 	}
 
-	/**
-	 * @param MediaWikiServices $services
-	 * @return Services
-	 */
 	public static function wrap( MediaWikiServices $services ): Services {
 		return new self( $services );
 	}
 
-	/** @param MediaWikiServices $services */
 	public function __construct( MediaWikiServices $services ) {
 		$this->services = $services;
 	}
 
-	/** @return NotificationServiceClient */
 	public function getPushNotificationServiceClient(): NotificationServiceClient {
 		return $this->services->getService( 'EchoPushNotificationServiceClient' );
 	}
 
-	/** @return SubscriptionManager */
 	public function getPushSubscriptionManager(): SubscriptionManager {
 		return $this->services->getService( 'EchoPushSubscriptionManager' );
 	}
 
-	/** @return AttributeManager */
 	public function getAttributeManager(): AttributeManager {
 		return $this->services->getService( 'EchoAttributeManager' );
 	}
 
-	/** @return TitleLocalCache */
 	public function getTitleLocalCache(): TitleLocalCache {
 		return $this->services->getService( 'EchoTitleLocalCache' );
 	}
 
-	/** @return RevisionLocalCache */
 	public function getRevisionLocalCache(): RevisionLocalCache {
 		return $this->services->getService( 'EchoRevisionLocalCache' );
 	}

includes/Special/NotificationPager.php

@@ -15,9 +15,7 @@ use MediaWiki\Pager\ReverseChronologicalPager;
  * It paginates on notification_event for a specific user, only for the enabled event types.
  */
 class NotificationPager extends ReverseChronologicalPager {
-	/**
-	 * @param IContextSource $context
-	 */
+
 	public function __construct( IContextSource $context ) {
 		$dbFactory = DbFactory::newFromDefault();
 		$this->mDb = $dbFactory->getEchoDb( DB_REPLICA );

includes/Special/SpecialDisplayNotificationsConfiguration.php

@@ -61,10 +61,6 @@ class SpecialDisplayNotificationsConfiguration extends UnlistedSpecialPage {
 	 */
 	private $userOptionsManager;
 
-	/**
-	 * @param AttributeManager $attributeManager
-	 * @param UserOptionsManager $userOptionsManager
-	 */
 	public function __construct(
 		AttributeManager $attributeManager,
 		UserOptionsManager $userOptionsManager