wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-09-23 18:30:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Defer onPersonalUrls() DB writes to post-send (try #2)

Browse source 
This reverts commit e372f3ce6f.

The previous attempt was broken because
EchoTargetPageMapper::fetchByUserPageId() returns a list of
EchoTargetPage objects, not a single one.

Bug: T117531
Change-Id: Id02a025e3736a7b92d9d6fb8adf29ef674f8e2fa
This commit is contained in:
Kunal Mehta 2016-03-09 11:01:42 -08:00
parent 51dd4fd109
commit 26a8bc2450
3 changed files with 55 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
Hooks.php
View file

@ -735,24 +735,42 @@ class EchoHooks {
return true;
}
// Attempt to mark a notification as read when visiting a page,
// ideally this should be deferred to end of request and update
// the notification count accordingly
// @Fixme - Find a better place to put this code
// Attempt to mark a notification as read when visiting a page
// @todo should this really be here?
$subtractAlerts = 0;
$subtractMessages = 0;
if ( $title->getArticleID() ) {
$mapper = new EchoTargetPageMapper();
$targetPages = $mapper->fetchByUserPageId( $user, $title->getArticleID() );
if ( $targetPages ) {
$eventIds = array_keys( $targetPages );
$notifUser = MWEchoNotifUser::newFromUser( $user );
$notifUser->markRead( $eventIds );
$fetchedTargetPages = $mapper->fetchByUserPageId( $user, $title->getArticleID() );
if ( $fetchedTargetPages ) {
$eventIds = array();
$attribManager = EchoAttributeManager::newFromGlobalVars();
/* @var EchoTargetPage[] $targetPages */
foreach ( $fetchedTargetPages as $id => $targetPages ) {
// Only look at the first target page since they'll
// all point to the same event
$section = $attribManager->getNotificationSection(
$targetPages[0]->getEventType()
);
if ( $section === EchoAttributeManager::MESSAGE ) {
$subtractMessages += 1;
} else {
// ALERT
$subtractAlerts += 1;
}
$eventIds[] = $id;
}
DeferredUpdates::addCallableUpdate( function () use ( $user, $eventIds ) {
$notifUser = MWEchoNotifUser::newFromUser( $user );
$notifUser->markRead( $eventIds );
} );
}
}
// Add a "My notifications" item to personal URLs
$notifUser = MWEchoNotifUser::newFromUser( $user );
$msgCount = $notifUser->getMessageCount();
$alertCount = $notifUser->getAlertCount();
$msgCount = $notifUser->getMessageCount() - $subtractMessages;
$alertCount = $notifUser->getAlertCount() - $subtractAlerts;
$msgNotificationTimestamp = $notifUser->getLastUnreadMessageTime();
$alertNotificationTimestamp = $notifUser->getLastUnreadAlertTime();

8
includes/mapper/TargetPageMapper.php
View file

@ -28,13 +28,15 @@ class EchoTargetPageMapper extends EchoAbstractMapper {
$dbr = $this->dbFactory->getEchoDb( DB_SLAVE );
$res = $dbr->select(
array( 'echo_target_page' ),
self::$fields,
array( 'echo_target_page', 'echo_event' ),
array_merge( self::$fields, array( 'event_type' ) ),
array(
'etp_user' => $user->getId(),
'etp_page' => $pageId
),
__METHOD__
__METHOD__,
array(),
array( 'echo_event' => array( 'JOIN', 'etp_event=event_id' ) )
);
if ( $res ) {
$targetPages = array();

22
includes/model/TargetPage.php
View file

@ -32,6 +32,11 @@ class EchoTargetPage extends EchoAbstractEntity {
*/
protected $eventId;
/**
* @var string
*/
protected $eventType;
/**
* Only allow creating instance internally
*/
@ -44,7 +49,7 @@ class EchoTargetPage extends EchoAbstractEntity {
* @param User $user
* @param Title $title
* @param EchoEvent $event
* @return TargetPage|null
* @return EchoTargetPage|null
*/
public static function create( User $user, Title $title, EchoEvent $event ) {
// This only support title with a page_id
@ -55,6 +60,7 @@ class EchoTargetPage extends EchoAbstractEntity {
$obj->user = $user;
$obj->event = $event;
$obj->eventId = $event->getId();
$obj->eventType = $event->getType();
$obj->title = $title;
$obj->pageId = $title->getArticleID();
@ -83,6 +89,9 @@ class EchoTargetPage extends EchoAbstractEntity {
$obj->user = User::newFromId( $row->etp_user );
$obj->pageId = $row->etp_page;
$obj->eventId = $row->etp_event;
if ( isset( $row->event_type ) ) {
$obj->eventType = $row->event_type;
}
return $obj;
}
@ -130,6 +139,17 @@ class EchoTargetPage extends EchoAbstractEntity {
return $this->eventId;
}
/**
* @return string
*/
public function getEventType() {
if ( !$this->eventType ) {
$this->eventType = $this->getEvent()->getType();
}
return $this->eventType;
}
/**
* Convert the properties to a database row
* @return array