wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-24 07:54:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clean up some code in EchoEmailBatch

Browse source 
* Address TODO to use a constant instead of hardcoding
* Only call User::getOption() once

Change-Id: I52d8c3698f8d915ec9d96de0976d242009b3df39
This commit is contained in:
Kunal Mehta 2016-03-08 15:32:27 -08:00
parent e56b5d00ab
commit 210f3a1d4a
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
includes/EmailBatch.php
View file

@ -240,8 +240,9 @@ class MWEchoEmailBatch {
public function sendEmail() {
global $wgNotificationSender, $wgNotificationReplyName;
// @Todo - replace them with the CONSTANT in 33810 once it is merged
if ( $this->mUser->getOption( 'echo-email-frequency' ) == 7 ) {
if ( $this->mUser->getOption( 'echo-email-frequency' )
== EchoHooks::EMAIL_WEEKLY_DIGEST
) {
$frequency = 'weekly';
$emailDeliveryMode = 'weekly_digest';
} else {
@ -265,10 +266,11 @@ class MWEchoEmailBatch {
);
}
$userLangCode = $this->mUser->getOption( 'language' );
// email subject
if ( $this->count > self::$displaySize ) {
$count = wfMessage( 'echo-notification-count' )
->inLanguage( $this->mUser->getOption( 'language' ) )
->inLanguage( $userLangCode )
->params( self::$displaySize )->text();
} else {
$count = $this->count;
@ -276,7 +278,7 @@ class MWEchoEmailBatch {
// Give grep a chance to find the usages:
// echo-email-batch-subject-daily, echo-email-batch-subject-weekly
$subject = wfMessage( 'echo-email-batch-subject-' . $frequency )
->inLanguage( $this->mUser->getOption( 'language' ) )
->inLanguage( $userLangCode )
->params( $count, $this->count )->text();
$toAddress = MailAddress::newFromUser( $this->mUser );