wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-12 09:26:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Avoid use of IDatabase::delete() return values"

Browse source
This commit is contained in:
jenkins-bot 2018-10-28 21:42:10 +00:00 committed by Gerrit Code Review
parent 512a0904c5 9aa1344808
commit 155d582026
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
includes/mapper/NotificationMapper.php
View file

@ -399,20 +399,19 @@ class EchoNotificationMapper extends EchoAbstractMapper {
if ( !$idsToDelete ) {
return true;
}
$success = true;
foreach ( array_chunk( $idsToDelete, $wgUpdateRowsPerQuery ) as $batch ) {
$success = $dbw->delete(
$dbw->delete(
'echo_notification',
[
'notification_user' => $userId,
'notification_event' => $batch,
],
__METHOD__
) && $success;
);
$lbFactory->commitAndWaitForReplication(
__METHOD__, $ticket, [ 'domain' => $domainId ] );
}
return $success;
return true;
}
/**