wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-24 16:04:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a code comment to make it much clearer

Browse source 
Change-Id: Ibd7c1e050f0d0790c1712a950568e3f9b09965ca
This commit is contained in:
Moriel Schottlender 2015-09-17 16:43:36 -07:00
parent 24d83a8a32
commit 1474a21d4a
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
modules/ooui/mw.echo.ui.NotificationBadgeWidget.js
View file

@ -195,11 +195,12 @@
var widget = this,
time = mw.now();
// The model retrieves the fetching notifications or returns the existing one
// but in the case of an error from the API, the fetching promise is not being
// reset to null.
// We should reset the notification population method if the model is either not
// in the process of fetching notifications or if it is in an error state
// The model retrieves the ongoing promise or returns the existing one that it
// has. When the promise is completed successfuly, it nullifies itself so we can
// request for it to be rebuilt and the request to the API resent.
// However, in the case of an API failure, the promise does not nullify itself.
// In that case we also want the model to rebuild the request, so in this condition
// we must check both cases.
if ( !this.notificationsModel.isFetchingNotifications() || this.notificationsModel.isFetchingErrorState() ) {
this.pushPending();
this.markAllReadButton.toggle( false );