wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-24 07:54:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't export unused wgEchoOverlayConfiguration/wgEchoHelpPage JS variables

Browse source 
And make the if conditional a little easier to read: is logged in versus
not anonymous.

Change-Id: I76784b74caabd1ea0a5f0f506661a1682c865394
This commit is contained in:
Kunal Mehta 2015-11-12 10:38:04 -08:00
parent b46fcf57b3
commit 0790125dd4
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
Hooks.php
View file

@ -812,17 +812,12 @@ class EchoHooks {
* @return bool true in all cases
*/
public static function makeGlobalVariablesScript( &$vars, OutputPage $outputPage ) {
global $wgEchoHelpPage, $wgEchoMaxNotificationCount, $wgEchoConfig;
global $wgEchoConfig;
$user = $outputPage->getUser();
// Provide info for the Overlay
if ( !$user->isAnon() ) {
$vars['wgEchoOverlayConfiguration'] = array(
'notification-count' => MWEchoNotifUser::newFromUser( $user )->getFormattedNotificationCount(),
'max-notification-count' => $wgEchoMaxNotificationCount,
);
$vars['wgEchoHelpPage'] = $wgEchoHelpPage;
if ( $user->isLoggedIn() ) {
$vars['wgEchoConfig'] = $wgEchoConfig;
} elseif (
$outputPage->getTitle()->equals( SpecialPage::getTitleFor( 'JavaScriptTest', 'qunit' ) ) ||