wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-28 01:30:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Work around regression in OO.ui.FloatableElement

Browse source 
FloatableElement incorrectly believes it doesn't need to
position itself when its closest scrollable is the same as
the closest scrollable of the container. This causes
the dotdotdot menu to be placed at the top left of the screen
if the notifications popup is not scrollable. If it is scrollable,
everything works fine. This regression was introduced by I5b5d7936c4d.

Work around this by setting overflow-x: auto; on the popup body.
This is a no-op, but tricks OOUI into thinking that the popup
body is scrollable even when it visually isn't. We can't use
overflow-y for this, because we still need to set overflow-y: auto;
on the popup body to work around a Chrome bug where right-floated
elements don't move over when the scrollbar appears.

Bug: T130153
Change-Id: I8bd8a26a4931444a760d2159779240272c51f966
This commit is contained in:
Roan Kattouw 2016-03-16 15:40:27 -07:00
parent 059b368e2d
commit 02252d0531
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/ooui/styles/mw.echo.ui.NotificationBadgeWidget.less
View file

@ -38,7 +38,9 @@
> .oo-ui-popupWidget-body { > .oo-ui-popupWidget-body {
// Work around scrollbar rendering bug in Chrome // Work around scrollbar rendering bug in Chrome
overflow: visible; overflow-y: visible;
// Work around OO.ui.FloatableElement bug (T130153)
overflow-x: auto;
} }
> .oo-ui-popupWidget-footer { > .oo-ui-popupWidget-footer {