wikimedia/mediawiki-extensions-Echo
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Echo synced 2024-11-24 07:54:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "(bug 48521) Echo should not implicitly commit other transaction"

Browse source
This commit is contained in:
jenkins-bot 2013-05-22 19:37:41 +00:00 committed by Gerrit Code Review
parent bc64c5a3d0 51aa0de16a
commit 021a9213be
1 changed files with 23 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
includes/DbEchoBackend.php
View file

@ -10,24 +10,30 @@ class MWDbEchoBackend extends MWEchoBackend {
*/
public function createNotification( $row ) {
$dbw = MWEchoDbFactory::getDB( DB_MASTER );
$dbw->begin( __METHOD__ );
// reset the base if this notification has a display hash
if ( $row['notification_bundle_display_hash'] ) {
$dbw->update(
'echo_notification',
array( 'notification_bundle_base' => 0 ),
array(
'notification_user' => $row['notification_user'],
'notification_bundle_display_hash' => $row['notification_bundle_display_hash'],
'notification_bundle_base' => 1
),
__METHOD__
);
}
$row['notification_timestamp'] = $dbw->timestamp( $row['notification_timestamp'] );
$dbw->insert( 'echo_notification', $row, __METHOD__ );
$dbw->commit( __METHOD__ );
$fname = __METHOD__;
$dbw->onTransactionIdle(
function() use ( $dbw, $row, $fname ) {
$dbw->begin( $fname );
// reset the base if this notification has a display hash
if ( $row['notification_bundle_display_hash'] ) {
$dbw->update(
'echo_notification',
array( 'notification_bundle_base' => 0 ),
array(
'notification_user' => $row['notification_user'],
'notification_bundle_display_hash' => $row['notification_bundle_display_hash'],
'notification_bundle_base' => 1
),
$fname
);
}
$row['notification_timestamp'] = $dbw->timestamp( $row['notification_timestamp'] );
$dbw->insert( 'echo_notification', $row, $fname );
$dbw->commit( $fname );
}
);
}
/**