mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools
synced 2024-11-28 02:00:57 +00:00
045b020ca4
Exposes that the old parser tests are asserting 0 comments added. The tests are passing becaause testUtils.getThreadContainer returns the empty string for both actual and expected. Change-Id: I263a258a8db5c35a6fb1fc5ce281f902fc543038
151 lines
4.7 KiB
JavaScript
151 lines
4.7 KiB
JavaScript
var
|
|
testUtils = require( './testUtils.js' ),
|
|
Parser = require( 'ext.discussionTools.init' ).Parser,
|
|
modifier = require( 'ext.discussionTools.init' ).modifier;
|
|
|
|
QUnit.module( 'mw.dt.modifier', QUnit.newMwEnvironment() );
|
|
|
|
require( '../cases/modified.json' ).forEach( function ( caseItem ) {
|
|
var testName = '#addListItem/#removeAddedListItem (' + caseItem.name + ')';
|
|
// This should be one test with many cases, rather than multiple tests, but the cases are large
|
|
// enough that processing all of them at once causes timeouts in Karma test runner.
|
|
// FIXME: Actually, even single test cases cause timeouts now. Skip the slowest ones.
|
|
var skipTests = [
|
|
'enwiki oldparser',
|
|
'enwiki parsoid',
|
|
'enwiki oldparser (bullet indentation)',
|
|
'enwiki parsoid (bullet indentation)'
|
|
];
|
|
if ( skipTests.indexOf( caseItem.name ) !== -1 ) {
|
|
QUnit.skip( testName );
|
|
return;
|
|
}
|
|
QUnit.test( testName, function ( assert ) {
|
|
var fixture = document.getElementById( 'qunit-fixture' );
|
|
|
|
var dom = mw.template.get( 'test.DiscussionTools', caseItem.dom ).render(),
|
|
expected = mw.template.get( 'test.DiscussionTools', caseItem.expected ).render(),
|
|
config = require( caseItem.config ),
|
|
data = require( caseItem.data ),
|
|
title = mw.Title.newFromText( caseItem.title );
|
|
|
|
testUtils.overrideMwConfig( config );
|
|
|
|
$( fixture ).empty().append( testUtils.getThreadContainer( expected ).children() );
|
|
var expectedHtml = fixture.innerHTML;
|
|
|
|
$( fixture ).empty().append( testUtils.getThreadContainer( dom ).children() );
|
|
var reverseExpectedHtml = fixture.innerHTML;
|
|
|
|
var threadItemSet = new Parser( data ).parse( fixture, title );
|
|
var comments = threadItemSet.getCommentItems();
|
|
|
|
// Add a reply to every comment. Note that this inserts *all* of the replies, unlike the real
|
|
// thing, which only deals with one at a time. This isn't ideal but resetting everything after
|
|
// every reply would be super slow.
|
|
var nodes = [];
|
|
comments.forEach( function ( comment ) {
|
|
var node = modifier.addListItem( comment, caseItem.replyIndentation || 'invisible' );
|
|
node.textContent = 'Reply to ' + comment.id;
|
|
nodes.push( node );
|
|
} );
|
|
|
|
// Uncomment this to get updated content for the "modified HTML" files, for copy/paste:
|
|
// console.log( fixture.innerHTML );
|
|
|
|
var actualHtml = fixture.innerHTML;
|
|
|
|
assert.strictEqual(
|
|
actualHtml,
|
|
expectedHtml,
|
|
comments.length + ' replies added'
|
|
);
|
|
|
|
// Now discard the replies and verify we get the original document back.
|
|
nodes.forEach( function ( node ) {
|
|
modifier.removeAddedListItem( node );
|
|
} );
|
|
|
|
var reverseActualHtml = fixture.innerHTML;
|
|
assert.strictEqual(
|
|
reverseActualHtml,
|
|
reverseExpectedHtml,
|
|
nodes.length + ' replies removed'
|
|
);
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( '#addReplyLink', function ( assert ) {
|
|
var cases = require( '../cases/reply.json' ),
|
|
fixture = document.getElementById( 'qunit-fixture' );
|
|
|
|
cases.forEach( function ( caseItem ) {
|
|
var dom = mw.template.get( 'test.DiscussionTools', caseItem.dom ).render(),
|
|
expected = mw.template.get( 'test.DiscussionTools', caseItem.expected ).render(),
|
|
config = require( caseItem.config ),
|
|
data = require( caseItem.data ),
|
|
title = mw.Title.newFromText( caseItem.title );
|
|
|
|
testUtils.overrideMwConfig( config );
|
|
|
|
$( fixture ).empty().append( testUtils.getThreadContainer( expected ).children() );
|
|
var expectedHtml = fixture.innerHTML;
|
|
|
|
$( fixture ).empty().append( testUtils.getThreadContainer( dom ).children() );
|
|
|
|
var threadItemSet = new Parser( data ).parse( fixture, title );
|
|
var comments = threadItemSet.getCommentItems();
|
|
|
|
// Add a reply link to every comment.
|
|
comments.forEach( function ( comment ) {
|
|
var linkNode = document.createElement( 'a' );
|
|
linkNode.textContent = 'Reply';
|
|
linkNode.href = '#';
|
|
modifier.addReplyLink( comment, linkNode );
|
|
} );
|
|
|
|
// Uncomment this to get updated content for the "reply HTML" files, for copy/paste:
|
|
// console.log( fixture.innerHTML );
|
|
|
|
var actualHtml = fixture.innerHTML;
|
|
|
|
assert.strictEqual(
|
|
actualHtml,
|
|
expectedHtml,
|
|
caseItem.name
|
|
);
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( '#unwrapList', function ( assert ) {
|
|
var cases = require( '../cases/unwrap.json' );
|
|
|
|
cases.forEach( function ( caseItem ) {
|
|
var container = document.createElement( 'div' );
|
|
|
|
container.innerHTML = caseItem.html;
|
|
modifier.unwrapList( container.childNodes[ caseItem.index || 0 ] );
|
|
|
|
assert.strictEqual(
|
|
container.innerHTML,
|
|
caseItem.expected,
|
|
caseItem.name
|
|
);
|
|
} );
|
|
} );
|
|
|
|
QUnit.test( 'sanitizeWikitextLinebreaks', function ( assert ) {
|
|
var cases = require( '../cases/sanitize-wikitext-linebreaks.json' );
|
|
|
|
cases.forEach( function ( caseItem ) {
|
|
assert.strictEqual(
|
|
modifier.sanitizeWikitextLinebreaks( caseItem.wikitext ),
|
|
caseItem.expected,
|
|
caseItem.msg
|
|
);
|
|
} );
|
|
} );
|
|
|
|
// TODO:
|
|
// * addSiblingListItem
|