mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools
synced 2024-11-13 18:37:07 +00:00
2308d9bba0
The <exclude name=".."/> is managed by libup and when a rule passed, it get removed from the list. Failing rules on update are added. Setting the severity for the rule to none avoid that this is changed by libup and it is more visible, that the disable is wanted and there is nothing to "fix" as usually assumend for sniffs in the exclude list. Follow-Up: I8adfdce01ea96f4b62dabd3dea130f9593c7e5ac Change-Id: If42dade02c6ceed1e00f5a3dc846e1578b960ca6
26 lines
967 B
XML
26 lines
967 B
XML
<?xml version="1.0"?>
|
|
<ruleset>
|
|
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki" />
|
|
|
|
<!--
|
|
Code such as this:
|
|
while ( ( $foo = $foo->nextSibling ) && someCondition( $foo ) ) { … }
|
|
is often convenient when working on DOM tree structures, which we do a lot of in this extension.
|
|
|
|
It's particularly helpful in combination with Phan, which can infer that `$foo` is non-null from
|
|
the code above, but it can't infer that `$foo->nextSibling` is non-null in code like this:
|
|
while ( $foo->nextSibling && someCondition( $foo->nextSibling ) ) { … }
|
|
|
|
When the variable is the only condition, we add extra parentheses to indicate that it isn't a
|
|
typo for `==`, which is a convention borrowed from C:
|
|
while ( ( $foo = $foo->nextSibling ) ) { … }
|
|
-->
|
|
<rule ref="Generic.CodeAnalysis.AssignmentInCondition">
|
|
<severity>0</severity>
|
|
</rule>
|
|
|
|
<file>.</file>
|
|
<arg name="extensions" value="php" />
|
|
<arg name="encoding" value="UTF-8" />
|
|
</ruleset>
|