mediawiki-extensions-Discus.../includes/ApiDiscussionToolsCompare.php
Bartosz Dziewoński 8e44b43df0 Split off ThreadItemSet from CommentParser
Goal:
-----
Finishing the work from Iadb7757debe000025e52770ca51ebcf24ca8ee66
by changing CommentParser::parse() to return a data object, instead of
the whole parser.

Changes:
--------
ThreadItemSet.php:
ThreadItemSet.js:
* New data class to access the results of parsing a discussion. Most
  methods and properties are moved from CommentParser with no changes.

CommentParser.php:
Parser.js:
* parse() returns a new ThreadItemSet.
* Remove methods moved to ThreadItemSet.
* Placeholder headings are generated slightly differently, as we process
  things in a different order.
* Grouping threads and computing IDs/names is no longer lazy. We always
  needed IDs/names anyway.
* computeId() explicitly uses a ThreadItemSet to check the existing IDs
  when de-duplicating.

controller.js:
* Move the code for turning some nodes annotated by CommentFormatter
  into a ThreadItemSet (previously a Parser) from controller#init to
  ThreadItemSet.static.newFromAnnotatedNodes, and rewrite it to handle
  assigning parents/replies and recalculating legacy IDs more nicely.
* mw.dt.pageThreads is now a ThreadItemSet.

Change-Id: I49bfe019aa460651447fd383f73eafa9d7180a92
2022-02-21 16:22:32 +00:00

156 lines
3.9 KiB
PHP

<?php
namespace MediaWiki\Extension\DiscussionTools;
use ApiBase;
use ApiMain;
use ApiParsoidTrait;
use MediaWiki\Revision\RevisionRecord;
use Title;
use Wikimedia\ParamValidator\ParamValidator;
class ApiDiscussionToolsCompare extends ApiBase {
use ApiDiscussionToolsTrait;
use ApiParsoidTrait;
/**
* @inheritDoc
*/
public function __construct( ApiMain $main, string $name ) {
parent::__construct( $main, $name );
}
/**
* @inheritDoc
*/
public function execute() {
$params = $this->extractRequestParams();
$this->requireOnlyOneParameter( $params, 'fromtitle', 'fromrev' );
$this->requireOnlyOneParameter( $params, 'totitle', 'torev' );
if ( $params['torev'] ) {
$toRev = $this->getValidRevision( null, $params['torev'] ?? null );
} else {
$toTitle = Title::newFromText( $params['totitle'] );
if ( !$toTitle ) {
$this->dieWithError( [ 'apierror-invalidtitle', wfEscapeWikiText( $params['totitle'] ) ] );
}
$toRev = $this->getValidRevision( $toTitle );
}
// When polling for new comments this is an important optimisation,
// as usually there is no new revision.
if ( $toRev->getId() === $params['fromrev'] ) {
$this->addResult( $toRev, $toRev );
return;
}
if ( $params['fromrev'] ) {
$fromRev = $this->getValidRevision( null, $params['fromrev'] ?? null );
} else {
$fromTitle = Title::newFromText( $params['fromtitle'] );
if ( !$fromTitle ) {
$this->dieWithError( [ 'apierror-invalidtitle', wfEscapeWikiText( $params['fromtitle'] ) ] );
}
$fromRev = $this->getValidRevision( $fromTitle );
}
if ( $fromRev->hasSameContent( $toRev ) ) {
$this->addResult( $fromRev, $toRev );
return;
}
$fromItemSet = $this->parseRevision( $fromRev );
$toItemSet = $this->parseRevision( $toRev );
$removedComments = [];
foreach ( $fromItemSet->getCommentItems() as $fromComment ) {
if ( !$toItemSet->findCommentById( $fromComment->getId() ) ) {
$removedComments[] = $fromComment->jsonSerializeForDiff();
}
}
$addedComments = [];
foreach ( $toItemSet->getCommentItems() as $toComment ) {
if ( !$fromItemSet->findCommentById( $toComment->getId() ) ) {
$addedComments[] = $toComment->jsonSerializeForDiff();
}
}
$this->addResult( $fromRev, $toRev, $removedComments, $addedComments );
}
/**
* Add the result object from revisions and comment lists
*
* @param RevisionRecord $fromRev From revision
* @param RevisionRecord $toRev To revision
* @param array $removedComments Removed comments
* @param array $addedComments Added comments
*/
protected function addResult(
RevisionRecord $fromRev, RevisionRecord $toRev, array $removedComments = [], array $addedComments = []
) {
$fromTitle = Title::newFromLinkTarget(
$fromRev->getPageAsLinkTarget()
);
$toTitle = Title::newFromLinkTarget(
$toRev->getPageAsLinkTarget()
);
$result = [
'fromrevid' => $fromRev->getId(),
'fromtitle' => $fromTitle->getPrefixedText(),
'torevid' => $toRev->getId(),
'totitle' => $toTitle->getPrefixedText(),
'removedcomments' => $removedComments,
'addedcomments' => $addedComments,
];
$this->getResult()->addValue( null, $this->getModuleName(), $result );
}
/**
* @inheritDoc
*/
public function getAllowedParams() {
return [
'fromtitle' => [
ApiBase::PARAM_HELP_MSG => 'apihelp-compare-param-fromtitle',
],
'fromrev' => [
ParamValidator::PARAM_TYPE => 'integer',
ApiBase::PARAM_HELP_MSG => 'apihelp-compare-param-fromrev',
],
'totitle' => [
ApiBase::PARAM_HELP_MSG => 'apihelp-compare-param-totitle',
],
'torev' => [
ParamValidator::PARAM_TYPE => 'integer',
ApiBase::PARAM_HELP_MSG => 'apihelp-compare-param-torev',
],
];
}
/**
* @inheritDoc
*/
public function needsToken() {
return false;
}
/**
* @inheritDoc
*/
public function isInternal() {
return true;
}
/**
* @inheritDoc
*/
public function isWriteMode() {
return false;
}
}