mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools
synced 2024-11-25 00:38:33 +00:00
8b73612585
We can just use insertBefore() normally. There was never a PHP bug,
but rather a Phan bug, and it no longer affects us.
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/596813/70/includes/ImmutableRange.php#373
This reveals a bug in CommentParser where it sometimes produces
incorrect ranges (we were incorrectly treating `false` like `null`,
hiding the issue). I'll fix it in a separate commit.
Follow-up to
|
||
---|---|---|
.. | ||
Actions | ||
Hooks | ||
Notifications | ||
ApiDiscussionTools.php | ||
ApiDiscussionToolsEdit.php | ||
ApiDiscussionToolsSubscribe.php | ||
CommentFormatter.php | ||
CommentItem.php | ||
CommentModifier.php | ||
CommentParser.php | ||
CommentUtils.php | ||
Data.php | ||
HeadingItem.php | ||
ImmutableRange.php | ||
NodeFilter.php | ||
ServiceWiring.php | ||
SubscriptionItem.php | ||
SubscriptionStore.php | ||
ThreadItem.php | ||
TreeWalker.php |