mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools
synced 2024-12-18 11:02:57 +00:00
42ce942c86
The existing comment IDs can't be used to find the same comment on a different revision or page (when it's transcluded), because they depend on the comment's parent and its position on the page. Comment names depend only on the author and timestamp. The trade-off is that they can't distinguish comments posted within the same minute, or in the same edit, so we will still need the IDs sometimes. Prefer using comment names when replying, if they're not ambiguous. This fixes T273413 and T275821. Heading names depend on the author and timestamp of the oldest comment. This way we don't have to detect changes to the heading text, but we can't distinguish headings without any comments. Bug: T274685 Bug: T273413 Bug: T275821 Change-Id: Id85c50ba38d1e532cec106708c077b908a3fcd49 |
||
---|---|---|
.. | ||
ar-nbsp-timezone-oldparser | ||
ar-nbsp-timezone-parsoid | ||
ar-no-paragraph-oldparser | ||
ar-no-paragraph-parsoid | ||
ckb-big-oldparser | ||
ckb-big-parsoid | ||
double-signature1 | ||
double-signature2 | ||
en-big-oldparser | ||
en-big-parsoid | ||
en-bigafd-parsoid | ||
fallback-encoding-link | ||
for-parser-cache | ||
fr-unsigned-oldparser | ||
fr-unsigned-parsoid | ||
it-unsigned-oldparser | ||
it-unsigned-parsoid | ||
linearWalk | ||
lrm-signature | ||
mixed-indentation | ||
no-heading | ||
parsoid-sections | ||
pl-big-oldparser | ||
pl-big-parsoid | ||
signatures-comments | ||
signatures-funny | ||
split-list | ||
split-list2 | ||
sr-ec | ||
sr-el | ||
transclusions | ||
unclosed-font | ||
wrappers | ||
appendSignature.json | ||
authors.json | ||
comments.json | ||
datatest-ckb.json | ||
datatest-en.json | ||
datatest-sr.json | ||
datatest-th.json | ||
formattedreply.json | ||
isHtmlSigned.json | ||
isWikitextSigned.json | ||
linearWalk.json | ||
modified.json | ||
README.txt | ||
reply.json | ||
sanitize-wikitext-linebreaks.json | ||
timestamp-parser-dst.json | ||
timestamp-parser.json | ||
timestamp-regex.json | ||
transcluded.json | ||
unwrap.json |
To update the expected outputs, run the PHP tests with the environment variable "DISCUSSIONTOOLS_OVERWRITE_TESTS" set to any value, e.g.: DISCUSSIONTOOLS_OVERWRITE_TESTS=1 php tests/phpunit/phpunit.php extensions/DiscussionTools/tests/phpunit/ The input HTML files were saved from: pl-big: https://pl.wikipedia.org/w/index.php?action=render&title=Wikipedia:Kawiarenka/Artyku%C5%82y_dyskusja/Archiwum/2018-pa%C5%BAdziernik&oldid=55171451 https://pl.wikipedia.org/api/rest_v1/page/html/Wikipedia%3AKawiarenka%2FArtyku%C5%82y_dyskusja%2FArchiwum%2F2018-pa%C5%BAdziernik/55171451 en-big: https://en.wikipedia.org/w/index.php?action=render&title=Wikipedia:Village_pump_(technical)/Archive_175&oldid=913983958 https://en.wikipedia.org/api/rest_v1/page/html/Wikipedia%3AVillage_pump_(technical)%2FArchive_175/913983958 ckb-big: https://ckb.wikipedia.org/w/index.php?title=ویکیپیدیا:دیوەخان_(پێشنیارەکان)&oldid=638545&action=render https://ckb.wikipedia.org/api/rest_v1/page/html/ویکیپیدیا%3Aدیوەخان_(پێشنیارەکان)/638545 en-bigafd: https://en.wikipedia.org/api/rest_v1/page/html/Wikipedia%3AArticles_for_deletion%2FLog%2F2020_March_7 ar-no-paragraph: https://ar.wikipedia.org/w/index.php?action=render&title=نقاش_المستخدم:Khaled&oldid=45576943 https://ar.wikipedia.org/api/rest_v1/page/html/نقاش_المستخدم%3AKhaled/45576943 ar-nbsp-timezone: https://ar.wikipedia.org/wiki/ويكيبيديا:إخفاء_أرقام_الآي_بي?oldid=46583196&action=render https://ar.wikipedia.org/api/rest_v1/page/html/ويكيبيديا%3Aإخفاء_أرقام_الآي_بي/46583196 fr-unsigned: https://fr.wikipedia.org/w/index.php?title=Discussion:Le_Monde&oldid=170426593&action=render https://fr.wikipedia.org/api/rest_v1/page/html/Discussion%3ALe_Monde/170426593 it-unsigned: https://it.wikipedia.org/w/index.php?title=Aiuto:Sportello_informazioni&oldid=116856029&action=render https://it.wikipedia.org/api/rest_v1/page/html/Aiuto%3ASportello_informazioni/116856029 sr-ec: https://sr.wikipedia.org/w/index.php?title=Википедија:Трг/Архива/Техника/35&variant=sr-ec&action=render sr-el: https://sr.wikipedia.org/w/index.php?title=Википедија:Трг/Архива/Техника/35&variant=sr-el&action=render unclosed-font: https://nl.wikipedia.org/w/index.php?title=Overleg_gebruiker:RYasmeen_(WMF)&oldid=57970619&action=render double-signature1: https://en.wikipedia.org/w/index.php?title=Wikipedia:Requests_for_comment/User_names&oldid=1002108637&action=render double-signature2: https://en.wikipedia.org/w/index.php?title=Wikipedia:Articles_for_deletion/Equal_Education&oldid=1009060583&action=render Text is available under the Creative Commons Attribution-ShareAlike License. See these pages for attribution.