mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools
synced 2024-11-16 20:58:28 +00:00
5203d30ea6
For compatibility with Parsoid's document abstraction (Parsoid may switch to an alternate DOM library in the future), don't explicitly create a new document object using `new DOMDocument`; instead use the Parsoid wrapper `DOMCompat::newDocument()`. This ensures that the Document object created will be compatible with Parsoid. There are a number of other subtle dependencies on the PHP `dom` extension in DiscussionTools, like explicit `instanceof` tests; those will be tweaked in a follow-up patch (I3c4f41c3819770f85d68157c9f690d650b7266a3) since they do not affect correctness so long as Parsoid is aliasing Document to a subclass of the built-in DOMDocument. Similarly, the Phan warnings we suppress do not cause runtime errors (because of the fixes included in c5265341afd9efde6b54ba56dc009aab88eff83c) but phan will be happier once the follow-up patch lands and aligns all the DOM types. Bug: T287611 Depends-On: If0671255779571a91d3472a9d90d0f2d69dd1f7d Change-Id: Ib98bd5b76de7a0d32a29840d1ce04379c72ef486
19 lines
1.5 KiB
PHP
19 lines
1.5 KiB
PHP
<?php
|
|
# For now, type check against the PHP `dom` extension.
|
|
# Eventually we'll want to type check against IDLeDOM, as Parsoid does.
|
|
// phpcs:disable Generic.Files.LineLength.TooLong
|
|
|
|
class_alias( "Wikimedia\\Parsoid\\DOM\\Compat\\Attr", "Wikimedia\\Parsoid\\DOM\\Attr" );
|
|
class_alias( "Wikimedia\\Parsoid\\DOM\\Compat\\CharacterData", "Wikimedia\\Parsoid\\DOM\\CharacterData" );
|
|
class_alias( "Wikimedia\\Parsoid\\DOM\\Compat\\Comment", "Wikimedia\\Parsoid\\DOM\\Comment" );
|
|
class_alias( "Wikimedia\\Parsoid\\DOM\\Compat\\Document", "Wikimedia\\Parsoid\\DOM\\Document" );
|
|
class_alias( "Wikimedia\\Parsoid\\DOM\\Compat\\DocumentFragment", "Wikimedia\\Parsoid\\DOM\\DocumentFragment" );
|
|
class_alias( "Wikimedia\\Parsoid\\DOM\\Compat\\DocumentType", "Wikimedia\\Parsoid\\DOM\\DocumentType" );
|
|
class_alias( "Wikimedia\\Parsoid\\DOM\\Compat\\DOMException", "Wikimedia\\Parsoid\\DOM\\DOMException" );
|
|
class_alias( "Wikimedia\\Parsoid\\DOM\\Compat\\DOMParser", "Wikimedia\\Parsoid\\DOM\\DOMParser" );
|
|
class_alias( "Wikimedia\\Parsoid\\DOM\\Compat\\Element", "Wikimedia\\Parsoid\\DOM\\Element" );
|
|
class_alias( "Wikimedia\\Parsoid\\DOM\\Compat\\Node", "Wikimedia\\Parsoid\\DOM\\Node" );
|
|
class_alias( "Wikimedia\\Parsoid\\DOM\\Compat\\NodeList", "Wikimedia\\Parsoid\\DOM\\NodeList" );
|
|
class_alias( "Wikimedia\\Parsoid\\DOM\\Compat\\ProcessingInstruction", "Wikimedia\\Parsoid\\DOM\\ProcessingInstruction" );
|
|
class_alias( "Wikimedia\\Parsoid\\DOM\\Compat\\Text", "Wikimedia\\Parsoid\\DOM\\Text" );
|