mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools
synced 2024-11-27 17:51:09 +00:00
4613ae78e7
Goal: ----- To have a method like CommentParser::parse(), which just takes a node to parse and a title and returns plain data, so that we don't need to keep track of the config to construct a CommentParser object (the required config like content language is provided by services) and we don't need to keep that object around after parsing. Changes: -------- CommentParser.php: * …is now a service. Constructor only takes services as arguments. The node and title are passed to a new parse() method. * parse() should return plain data, but I split this part to a separate patch for ease of review: I49bfe019aa460651447fd383f73eafa9d7180a92. * CommentParser still cheats and accesses global state in a few places, e.g. calling Title::makeTitleSafe or CommentUtils::getTitleFromUrl, so we can't turn its tests into true unit tests. This work is left for future commits. LanguageData.php: * …is now a service, instead of a static class. Parser.js: * …is not a real service, but it's changed to behave in a similar way. Constructor takes only the required config as argument, and node and title are instead passed to a new parse() method. CommentParserTest.php: parser.test.js: * Can be simplified, now that we don't need a useless node and title to test internal methods that don't use them. testUtils.js: * Can be simplified, now that we don't need to override internal ResourceLoader stuff just to change the parser config. Change-Id: Iadb7757debe000025e52770ca51ebcf24ca8ee66 |
||
|---|---|---|
| .. | ||
| Actions | ||
| Hooks | ||
| Notifications | ||
| ApiDiscussionToolsCompare.php | ||
| ApiDiscussionToolsEdit.php | ||
| ApiDiscussionToolsGetSubscriptions.php | ||
| ApiDiscussionToolsPageInfo.php | ||
| ApiDiscussionToolsSubscribe.php | ||
| ApiDiscussionToolsTrait.php | ||
| CommentFormatter.php | ||
| CommentItem.php | ||
| CommentModifier.php | ||
| CommentParser.php | ||
| CommentUtils.php | ||
| HeadingItem.php | ||
| ImmutableRange.php | ||
| LanguageData.php | ||
| NodeFilter.php | ||
| ResourceLoaderData.php | ||
| ServiceWiring.php | ||
| SpecialTopicSubscriptions.php | ||
| SubscriptionItem.php | ||
| SubscriptionStore.php | ||
| ThreadItem.php | ||
| TopicSubscriptionsPager.php | ||
| TreeWalker.php | ||