Go to file
Bartosz Dziewoński 30fcfec1fd parser: Merge multiple comments on one line
Even when you have multiple signatures by multiple users in one
paragraph (or list item), it's still basically a single comment.
We don't want to offer multiple buttons to reply to it.

The changed parser test cases are illustrative:
* All affected comments in the "pl" example are comments with a
  "post-scriptum", which is now more intuitively treated as part of
  the main comment.
* The first comment in the "en" example would probably have been
  better if it wasn't merged, but a weird use of the outdent template
  causes us to not be able to distinguish that the two parts of the
  comment display on separate lines.
* The last comment in the "en" example (isn't that neat?) was previously
  incorrectly treated as two comments, because there's a timestamp in
  the middle of it (the user is referring to another comment).
* Remaining affected comments in the "en" example are also comments
  with a "post-scriptum" and their treatment is clearly better now.

It also accidentally fixes some problems with modifier tests (but not
all), where previously <dl> nodes would be inserted in the middle of
<p> nodes, to reply to the comments which are now merged.

Bug: T240640
Change-Id: I0f2d9238aff75d78286250affd323cd145661a11
2020-01-22 02:21:43 +01:00
i18n Localisation updates from https://translatewiki.net. 2020-01-21 08:16:04 +01:00
includes build: Add missing .phpcs.xml and make pass 2020-01-13 20:48:11 +01:00
maintenance Call Maintenance::requireExtension 2020-01-13 22:15:43 +01:00
modules parser: Merge multiple comments on one line 2020-01-22 02:21:43 +01:00
tests parser: Merge multiple comments on one line 2020-01-22 02:21:43 +01:00
.eslintrc.json build: Updating npm dependencies 2020-01-09 06:43:15 +00:00
.gitignore Add .gitignore file 2019-10-10 21:21:00 +01:00
.gitreview Add .gitreview 2019-10-09 21:18:34 +00:00
.phpcs.xml build: Add missing .phpcs.xml and make pass 2020-01-13 20:48:11 +01:00
.stylelintrc.json build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 2020-01-14 04:55:38 +00:00
CODE_OF_CONDUCT.md build: Updating npm dependencies 2020-01-09 06:43:15 +00:00
composer.json build: Add phan-taint-check-plugin version 2020-01-17 18:13:25 +01:00
COPYING Add required files for an extension 2019-10-10 19:42:56 +01:00
extension.json Integration tests for the modifier 2020-01-22 00:58:06 +01:00
Gruntfile.js build: Updating npm dependencies 2020-01-09 06:43:15 +00:00
package-lock.json build: Updating npm dependencies 2020-01-09 06:43:15 +00:00
package.json build: Updating npm dependencies 2020-01-09 06:43:15 +00:00