mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools
synced 2024-12-22 04:46:27 +00:00
0b1919af0c
Follow-up to 3d9585acbe.
* Avoid deprecated method StatusValue::getErrors()
* Don't use exceptions for control flow
* Don't re-use Parsoid's ResourceLimitExceededException,
it seems unexpected to me and might limit future refactoring
* Use dieStatus() instead of dieWithException(), which will produce
better localised error messages
* Add missing error handling in ApiDiscussionToolsThank
Change-Id: Ia032025f92f1c3cc0d62a0f45925dddba93fb42f
60 lines
1.8 KiB
PHP
60 lines
1.8 KiB
PHP
<?php
|
|
/**
|
|
* DiscussionTools data updates hooks
|
|
*
|
|
* @file
|
|
* @ingroup Extensions
|
|
* @license MIT
|
|
*/
|
|
|
|
namespace MediaWiki\Extension\DiscussionTools\Hooks;
|
|
|
|
use MediaWiki\Deferred\DeferrableUpdate;
|
|
use MediaWiki\Deferred\MWCallableUpdate;
|
|
use MediaWiki\Extension\DiscussionTools\ThreadItemStore;
|
|
use MediaWiki\Revision\RenderedRevision;
|
|
use MediaWiki\Storage\Hook\RevisionDataUpdatesHook;
|
|
use MediaWiki\Title\Title;
|
|
use MWExceptionHandler;
|
|
use Throwable;
|
|
|
|
class DataUpdatesHooks implements RevisionDataUpdatesHook {
|
|
|
|
private ThreadItemStore $threadItemStore;
|
|
|
|
public function __construct(
|
|
ThreadItemStore $threadItemStore
|
|
) {
|
|
$this->threadItemStore = $threadItemStore;
|
|
}
|
|
|
|
/**
|
|
* @param Title $title
|
|
* @param RenderedRevision $renderedRevision
|
|
* @param DeferrableUpdate[] &$updates
|
|
* @return bool|void
|
|
*/
|
|
public function onRevisionDataUpdates( $title, $renderedRevision, &$updates ) {
|
|
// This doesn't trigger on action=purge, only on automatic purge after editing a template or
|
|
// transcluded page, and API action=purge&forcelinkupdate=1.
|
|
|
|
// TODO: Deduplicate the thread-item-processing done here with the Echo hook
|
|
// (which thread-item-processes the current and previous revisions).
|
|
$rev = $renderedRevision->getRevision();
|
|
if ( HookUtils::isAvailableForTitle( $title ) ) {
|
|
$method = __METHOD__;
|
|
$updates[] = new MWCallableUpdate( function () use ( $rev, $method ) {
|
|
try {
|
|
$threadItemSet = HookUtils::parseRevisionParsoidHtml( $rev, $method )->getValueOrThrow();
|
|
if ( !$this->threadItemStore->isDisabled() ) {
|
|
$this->threadItemStore->insertThreadItems( $rev, $threadItemSet );
|
|
}
|
|
} catch ( Throwable $e ) {
|
|
// Catch errors, so that they don't cause other updates to fail (T315383), but log them.
|
|
MWExceptionHandler::logException( $e );
|
|
}
|
|
}, __METHOD__ );
|
|
}
|
|
}
|
|
}
|