Commit graph

1250 commits

Author SHA1 Message Date
David Lynch fed37fcc82 preloadparams on other platforms supports numbered indexes
Change-Id: I4f1f5e8758007ab95e342ad5429c909f495d8deb
2023-04-01 22:49:06 +02:00
jenkins-bot e6282e9dd8 Merge "New topics notifications: Only highlight comments in new threads" 2023-03-30 21:33:00 +00:00
jenkins-bot 679fbba088 Merge "Log an EditAttemptStep session-abort when refreshing the page contents" 2023-03-30 21:32:57 +00:00
Ed Sanders e66327746a New topics notifications: Only highlight comments in new threads
Bug: T333476
Change-Id: I3f29c4b5a9be916d25415db18f50bd8efe6532af
2023-03-30 18:42:28 +00:00
Ed Sanders fd45c64491 Merge extra arguments to highlightNewComments into 'options'
Change-Id: I2e459b380ee8e1a63af5502eecf166189c9f6916
2023-03-30 16:40:52 +01:00
David Lynch 98bab18d91 Log an EditAttemptStep session-abort when refreshing the page contents
Depends-On: I0092789a425ed92e90c71b2125b195b61dcb49c3
Bug: T301582
Change-Id: I2ba94bf9ca28718dac69bb4b2b431471eff63abc
2023-03-28 22:55:45 -05:00
Ed Sanders 2fcc505d50 Parser: Store timestamp ranges
Change-Id: Ifcbe22011f11f4374f38b7aa346da5a96cac968c
2023-03-28 23:51:17 +00:00
jenkins-bot 9e51f11b8c Merge "Add new topics subscription button in Minerva" 2023-03-27 23:04:55 +00:00
Ed Sanders e6a255215f Add new topics subscription button in Minerva
Bug: T332730
Change-Id: Ib6915319eeae4aa32c875decd51e7fd8db4dbd16
2023-03-27 23:28:38 +01:00
jenkins-bot d08871fdae Merge "Centralize EditAttemptStep logging code in WikimediaEvents" 2023-03-27 15:30:43 +00:00
jenkins-bot 0bd7fe6f6b Merge "Fix [reply] spacing on mobile when usability improvements unavailable" 2023-03-25 09:10:06 +00:00
jenkins-bot 98f37c5e9e Merge "Add Special:DiscussionToolsDebug" 2023-03-24 16:25:04 +00:00
Bartosz Dziewoński 8d2304b3ed Add Special:DiscussionToolsDebug
It demonstrates how the DiscussionTools extension recognizes
the threads and comments present on a page, to help in debugging
or understanding its behavior.

Co-Authored-By: Ed Sanders <esanders@wikimedia.org>
Change-Id: Idbc90bd8d7742615178331889daae5f94a007fcc
2023-03-23 20:43:31 +01:00
Bartosz Dziewoński bfe4a81436 Fix [reply] spacing on mobile when usability improvements unavailable
Minerva uses block placement for the buttons only on pages where
usability improvements are available.

Follow-up to 869520a6d0.

Bug: T325416
Change-Id: I9e828197aea7bbaff86489f3ef6e256e0a0845ff
2023-03-23 00:17:18 +01:00
Ed Sanders d31254005f Update linters
Autofix some stylelint inssues

Change-Id: I5200899d253724a61bde127ccb00d8c0108af205
2023-03-22 22:38:41 +00:00
Umherirrender b7c74a34f4 build: Remove unneeded inline stylelint-disable-next-line
modules/dt.ui.ReplyWidget.less
  39:39  ✖  Needless disable for "no-duplicate-selectors"
--report-needless-disables
  65:2   ✖  Needless disable for "no-descending-specificity"
--report-needless-disables
 205:2   ✖  Needless disable for "no-descending-specificity"
--report-needless-disables

Change-Id: I233fdfbed46a9f8e75629d827b00007679063c29
2023-03-22 21:43:31 +01:00
Ed Sanders 80dd6e2d7c Add new topic subscription button to page actions
Bug: T263821
Change-Id: Iab7f7d5fd1f7c229c2e0cda9369676cfd401a24e
2023-03-20 14:51:10 +00:00
Ed Sanders 2bae1864bd New topic notifications
Bug: T263821
Change-Id: Ied465e732122a1ee39ab4510f73aca11ef556c35
2023-03-20 14:41:53 +00:00
Bartosz Dziewoński dcecf76ff1 Centralize EditAttemptStep logging code in WikimediaEvents
PHP logging code is not moved.

* Use the new mw.track() handlers from WikimediaEvents
* Ensure that 'integration' and 'editor_interface' are set on init
  events, since they're not hard-coded in the handler any more
* Remove the setting of 'editingStatsId' tracking parameter,
  now happens in WikimediaEvents (by way of VE ArticleTargetSaver)
* Remove code connecting ve.track to mw.track, now happens in VE

This must be merged together with WikimediaEvents change
Iace4d53a972396ca5b8713000570cc47c9986034 (but we can't use
Depends-On, because CI requires code here to be removed first).

Bug: T332438
Change-Id: I0ef0a96aafdf89a4ebe32131a85b18c25744bb2c
2023-03-18 13:26:10 +00:00
jenkins-bot 3ca1a43e2f Merge "Show usernames when display names are matched" 2023-03-16 19:36:49 +00:00
jenkins-bot f05699af82 Merge "ThreadItem: Add display names to getAuthorsBelow" 2023-03-16 19:36:48 +00:00
jenkins-bot 95019f563d Merge "CommentParser: Output display name if different to username" 2023-03-16 19:36:46 +00:00
Ed Sanders 37614a136f Show usernames when display names are matched
Also make our filter function match any substring of
the suggestion index (username + display names), as display
names often contain leading punctuation.

Bug: T266401
Depends-On: I69e5f54f7a8b7ca4126cc3ea513fc96e0a8606fb
Change-Id: I4e7429f8a88c3a82e981f37eb107c2b011482d73
2023-03-16 20:23:42 +01:00
jenkins-bot e87d68f8c0 Merge "Revert "Remove dtenable API hack"" 2023-03-15 16:25:22 +00:00
jenkins-bot 319b5be506 Merge "Disable section toggling on mobile when replying" 2023-03-13 14:41:46 +00:00
jenkins-bot 3fd625a6cc Merge "Allow overflow from section containers on mobile" 2023-03-09 22:54:43 +00:00
David Lynch 722ce7d6be Clicking "reply" was broken
Follow up to I4ee024cc4760542790319f302f42b1b2389ac897

Bug: T269310
Change-Id: Ibb7b3eda52965035ed34b101582fda32f6867ba0
2023-03-09 13:26:33 -06:00
David Lynch fbd5f575a4 Allow overflow from section containers on mobile
The ellipsis buttons in sections on mobile weren't able to properly show
their dropdowns or parts of their highlight because of the section
overflow we applied with visual enhancements. Because this was added for
a block context to contain the floating subscribe links, scope this to
mobile where that shouldn't be a concern.

Bug: T330536
Bug: T330537
Change-Id: Ic9787d6ca622a8f8bfbf9797353129e7fa40f4b7
2023-03-09 10:50:38 -06:00
jenkins-bot 663170fb2d Merge "Support '&preload=...' etc. in new topic tool when '&dtpreload=1' is set" 2023-03-08 20:55:32 +00:00
Ed Sanders 1453c1023d Disable section toggling on mobile when replying
Bug: T320753
Depends-On: I5e199d404b622fae014f1f9489f65464dab8295b
Change-Id: Ib6c92dc96484282fcc0773991b1a0a80fe97e962
2023-03-06 15:01:42 +00:00
Bartosz Dziewoński ffb8e164cb Revert "Remove dtenable API hack"
This reverts commit a1217913ae.

Unfortunately still needed. The reply links can be disabled by just
CSS, but to enable them, we also need to generate the HTML markup,
which isn't done unconditionally. An issue with links disappearing
was reported here:
https://en.wikipedia.org/wiki/Wikipedia_talk:Talk_pages_project#c-Pelagic-20230226035400-PPelberg_(WMF)-20230223000100

Change-Id: I905d3267191193362c278d23145912f4aa0ce139
2023-02-26 22:11:59 +00:00
Bartosz Dziewoński 79675507d2 Remove more unused CSS for .ext-discussiontools-init-replylink-divider
Follow-up to cf6c18f364.

Change-Id: I4af2062e708866ee1b9a0a5947fb5f9eb95c2bbb
2023-02-25 21:31:06 +01:00
jenkins-bot bfc2fb293f Merge "foreign-resources.yaml: Add extra fields" 2023-02-24 00:12:38 +00:00
jenkins-bot 843b24478a Merge "Undo inline-flex hack, fix alignment of buttons with text when wrapped" 2023-02-24 00:11:31 +00:00
jenkins-bot 9a3ac50afd Merge "Remove unused CSS for .ext-discussiontools-init-replylink-divider" 2023-02-24 00:06:05 +00:00
jenkins-bot 112ea30c01 Merge "Remove some px font-size overrides on topic metadata and buttons" 2023-02-24 00:04:47 +00:00
Bartosz Dziewoński 869520a6d0 Undo inline-flex hack, fix alignment of buttons with text when wrapped
Bug: T325416
Bug: T260072
Change-Id: I8f5daeeb9869ba3a23ffb45e6c5ec3b360d810c8
2023-02-24 00:16:47 +01:00
Reedy 27b14740ea foreign-resources.yaml: Add extra fields
Bug: T330432
Change-Id: Ia4926884c22dfd7019c8c7467850395646fad78c
2023-02-23 23:10:43 +00:00
Ed Sanders 79a62f539d ThreadItem: Add display names to getAuthorsBelow
Change-Id: I4195f982d7071fea0d0334908535639a11cdcae9
2023-02-23 23:03:35 +00:00
Ed Sanders b82af45735 CommentParser: Output display name if different to username
The only normalisation we apply for comparison is lowercasing.

Change-Id: Id3d57c2066429fcedc7dcc091e74ed46e17060f1
2023-02-23 23:03:32 +00:00
Bartosz Dziewoński cf6c18f364 Remove unused CSS for .ext-discussiontools-init-replylink-divider
Not used anywhere, not even in gadgets. I guess it was for other
planned features, but it can be added back when needed.

Change-Id: I858e8854567ffae6ff11ba61d99b4b09b12dc7d7
2023-02-23 23:26:03 +01:00
jenkins-bot b384a7ffc6 Merge "LedeSectionDialog: Fix double scrollbars in some cases" 2023-02-16 20:03:12 +00:00
jenkins-bot d3c451097b Merge "Special case opening new topic tool when VE or 2017WTE is open" 2023-02-16 16:47:16 +00:00
Bartosz Dziewoński 4b7ba72c83 LedeSectionDialog: Fix double scrollbars in some cases
There's no need for this PanelLayout to be scrollable, as the dialog
body itself is scrollable, and this is causing an unnecessary
horizontal scrollbar to appear on some pages (for example
https://de.m.wikipedia.org/wiki/Wikipedia_Diskussion:Hauptseite).

Change-Id: I516cae8ca006b57360fe85a2eba099913b38ce84
2023-02-16 01:04:14 +01:00
Bartosz Dziewoński 5af3e90fec Support '&preload=...' etc. in new topic tool when '&dtpreload=1' is set
To avoid affecting existing preload forms, the new topic tool is only
used when the 'dtpreload' query parameter is also set.

Bug: T269310
Change-Id: I4ee024cc4760542790319f302f42b1b2389ac897
2023-02-15 16:39:38 +01:00
Bartosz Dziewoński 55b0167868 ReplyLinksController: Fix teardown failing when reloading
Follow-up to 06919f9444 - applies the
same workaround in more places.

Bug: T329523
Change-Id: I265945b6ba44d735482e51e805319702a239a442
2023-02-13 15:46:58 +01:00
Bartosz Dziewoński 8eadff3b0d Optimize selectors in mobile hacks
See T328452#8587912

Bug: T328452
Change-Id: I584ef836d84cfa52ed003aae217c5c3b4e4ddbdd
2023-02-07 02:56:05 +01:00
Bartosz Dziewoński d0fb22a686 Special case opening new topic tool when VE or 2017WTE is open
Depends-On: Ica75f8334ef32ffbcc59109a46624acdf271847d
Bug: T317035
Change-Id: I87dc4b85df8deae5b16ae30a2ed054bfdcfdaa73
2023-02-06 23:04:10 +00:00
jenkins-bot daff9f6c27 Merge "Special:TopicSubscriptions: Perform unsubscribe asynchronously" 2023-02-06 23:01:01 +00:00
Ed Sanders a00d1b7a87 Hide (un)subscribe buttons when JS disabled
These buttons require JS to do anything. We can consider
providing a fallback action for subscriptions at a later date.

Change-Id: I9da546b2968e06d80c515eb5a05656a462b8201d
2023-02-06 22:36:14 +00:00