Ed Sanders
00042d8499
Remove DiscussionToolsEnableVisual config
...
Defaults to true and has no need to be disabled anymore.
Change-Id: I3cf9b5accea0fd1f175c75057641657742d8fa1b
2020-07-13 15:51:47 +01:00
Ed Sanders
58aa412fa3
Don't allow switching when unsupported content used
...
Bug: T256150
Change-Id: I9b57996f069a1c0c05ef396cfe0ed81495a1d9ec
2020-07-09 13:05:09 +01:00
Ed Sanders
94511c6bad
Add getHeading method to CommentItem
...
Change-Id: I14ccdbb432e835fe74760a52f07de172df2aba27
2020-07-01 17:21:15 +01:00
Ed Sanders
6459e7dc82
Move wikitext modifiers to modifier.js
...
Re-create methods in PHP.
Change-Id: Iae6117b65e3b8f50ecc68e1e3ea17c8359bdcb06
2020-07-01 17:06:02 +01:00
Ed Sanders
978eae5547
Move createCommentContainer to modifier
...
Refactor and create PHP versions.
Change-Id: I0ae9785e5fa86bcc1ac6eef9bce4088d7507dd33
2020-07-01 17:06:02 +01:00
Ed Sanders
fb0d2cbe7f
Move some postReply logic to modifier.js
...
Re-create the function in PHP
Change-Id: I1c8b505542c3b82c10b7b258e48054bc59cb4836
2020-07-01 17:06:02 +01:00
Ed Sanders
6d4d0962ef
CommentController: Refactor postReply
...
Separate out conversion to DOM nodes, and update
now that postReply doesn't need to return a promise.
Change-Id: Iab6192ba252244009d2374c9423d14279e8d1c4f
2020-07-01 17:06:02 +01:00
Ed Sanders
e7a9185ab1
Load VisualEditor plugin modules with ReplyWidgetVisual
...
Bug: T256292
Change-Id: Id05ad1871093e8941e54b2db8c9a76cecaac1033
2020-06-24 19:09:27 +01:00
Bartosz Dziewoński
b6edd8ddef
CommentController: Apply pre-save transform when switching to visual
...
Parsoid doesn't understand syntax expanded during pre-save transform,
e.g. [[User:Foo|]] or ~~~~, and it gets nowikied when switching back.
Change-Id: I791426d9d6c0a1399b1e95039b11e43a3e5bf79f
2020-06-22 21:01:55 +02:00
Ed Sanders
83968e4c00
Remove unsupported argument from getWikitextFragment
...
This was removed upstream due to a regression.
We don't need it right now, but may need it in the future to
support editing, so replace with a TODO.
Change-Id: Ia73657080241319df309f3b6566ac0ac36a5909d
2020-06-20 13:07:49 +01:00
jenkins-bot
b6695dae58
Merge "Strip RESTBase IDs when switching to VE"
2020-06-12 18:49:20 +00:00
jenkins-bot
02d049affe
Merge "Only re-focus the reply link when reply is abandoned"
2020-06-12 18:17:13 +00:00
jenkins-bot
6eb9824e8c
Merge "Add square brackets around reply link and use lower case (when possible)"
2020-06-12 18:11:20 +00:00
Ed Sanders
f2d3a00a7b
Follow-up Icb14766: Fix formatversion:2 param
...
Bug: T255083
Change-Id: I5636e8e21f45c50df31d05d535227cf909a45269
2020-06-11 18:27:30 +01:00
Ed Sanders
09857e13f1
Only re-focus the reply link when reply is abandoned
...
Bug: T252903
Change-Id: Iabac3eb2258ecd48f61e027950446f59dca68df3
2020-06-11 17:36:00 +01:00
Ed Sanders
d6d9aec3ee
Strip RESTBase IDs when switching to VE
...
Bug: T253584
Depends-On: If5d15dd4e7e0d3704ca8d75c0a25c529b06f17fb
Change-Id: Ia310fcc873960d0d3c1b17410e33dc4f47c5c734
2020-06-11 14:06:07 +00:00
jenkins-bot
edba40b1b6
Merge "Always use API formatversion: 2"
2020-06-09 19:25:15 +00:00
Ed Sanders
06eab3d961
Add square brackets around reply link and use lower case (when possible)
...
Bug: T249578
Change-Id: I5846106b10dc82231250d04a1f9ff025cfc1ca30
2020-06-09 19:55:14 +01:00
Ed Sanders
0cfc84aa29
Always use API formatversion: 2
...
Change-Id: Icb14766488beab76e24d1fedcc4b6214c6b04d98
2020-06-09 00:32:11 +00:00
David Lynch
5fa7d713d8
Logging: editor_interface should be visualeditor not visual.
...
Also, it should switch when the editor switches.
Bug: T254291
Change-Id: I2550529f51a8417586d6f0791d958fcf4b9d4fc6
2020-06-08 17:22:35 -05:00
Ed Sanders
0d14fcea6a
wt->visual: Don't unwrap template lists
...
Bug: T253150
Change-Id: I1584d9834e29c38edf4234f2f022c1c48bfd485f
2020-06-01 22:32:23 +01:00
jenkins-bot
576fe0ca36
Merge "Use current preference each time we open a new reply widget"
2020-06-01 19:10:59 +00:00
jenkins-bot
431ba1c87f
Merge "Make signature prefix customisable"
2020-06-01 17:18:04 +00:00
Ed Sanders
dada23e0f4
Make signature prefix customisable
...
Bug: T249861
Change-Id: I506a0c1b803275f5505fdf8ee29cc535814d7742
2020-06-01 18:55:04 +02:00
Ed Sanders
03a94badfe
Use current preference each time we open a new reply widget
...
TODO: Switch already setup widgets when we re-open them.
Bug: T253888
Change-Id: I6c541f27edbfe373f62b8508381bb5182681bda4
2020-05-29 13:06:36 +01:00
Ed Sanders
e064f43499
Remove empty lines in visual mode too
...
We already do this in source mode (sanitizeWikitextLinebreaks).
Bug: T253402
Change-Id: I10390b3173d22e8db735f5cd60180b1f48b94fff
2020-05-22 20:21:46 +01:00
Bartosz Dziewoński
fbd6338331
ReplyWidget: Avoid buttons shifting when switching to source
...
When the preview loads, the "Reply" / "Cancel" buttons shift downwards,
which looks ugly. Try to wait for the preview before showing the source
editor interface.
Bug: T234403
Change-Id: I70989fb9fbcac17e1a0672eda8d34bf26003bb96
2020-05-21 23:43:51 +02:00
Ed Sanders
9fbafef652
Add autosave support to visual mode
...
Bug: T240257
Change-Id: I87f8b68a5afee8d03c81cb283c9bee68ef9d4a5d
2020-05-20 22:16:20 +01:00
Ed Sanders
5feb69612f
Create a user preference to store visual/source mode
...
Bug: T250523
Depends-On: I5b3b47feeeca2085fcd283d55d7e9ceafa73be70
Change-Id: I18f5d38f9d694b12e5f983be7b3b165f135a890d
2020-05-20 22:16:19 +01:00
jenkins-bot
f5ac86528b
Merge "Show real error message when an exception is thrown"
2020-05-18 23:08:34 +00:00
Ed Sanders
607440498e
Spell check pass
...
Change-Id: Ia20da358297126bd52a968bd77c960f81fe82b8f
2020-05-18 21:24:14 +00:00
Ed Sanders
d1e58841af
Rename removeListItem to removeAddedListItem and remove in PHP
...
This method shouldn't be required on the server. Leave comments
relating to it in addListItem so JS & PHP can be kept in sync.
Change-Id: I849fac660faf6e750272c20776f96b9250f96b1b
2020-05-18 19:25:08 +00:00
Ed Sanders
5e996fdfdd
Modifier: Pass document to createWikitext
...
Change-Id: I1793e1d690835af746a4e25a50e2e0a474811e8e
2020-05-15 22:47:54 +01:00
Bartosz Dziewoński
6237f0fe0f
Show real error message when an exception is thrown
...
Exceptions were being treated like API errors, resulting in the
incorrect message "Invalid response from server." being shown to the
user. Instead show the error message.
Bug: T252238
Change-Id: Idbaee7d2b710812673992d30a17a9b5fe856a5a6
2020-05-11 19:04:54 +02:00
David Lynch
2f92e5d114
Disable VisualEditor page takeovers while a reply widget is open
...
This allows the unload handler to trigger on these links.
Depends-On: If52aa9d619eac08456874fc75c0f6e1adff01246
Bug: T244942
Change-Id: I9904e8af4a60b0f5e9a6e263cd4fd8e1e3fd1f98
2020-05-07 21:46:15 +02:00
Ed Sanders
9fab4add17
Config: Separate useVisualEditor into enableVisual and use2017Wikitext
...
Currently use2017Wikitext is missing some implementations.
Change-Id: Ib5f9bcc588561a80ca11de85518e6fae64e5b104
2020-05-06 18:03:36 +01:00
Ed Sanders
56d8721fd7
Switching between VE & wikitext (plain)
...
Bug: T234403
Change-Id: I84a639ab8e31ec9f683a63b0ecf184f426df09dd
2020-05-06 18:03:36 +01:00
Ed Sanders
d18496f025
Allow visual mode to tested with ?dtvisual=1
...
Bug: T251963
Change-Id: Ie86ed2097e3dc008f73d9b498627f9d025b865d5
2020-05-06 18:03:12 +01:00
David Lynch
b7ad053105
@Username completion in VE (source or visual) mode
...
Bug: T232601
Depends-On: I075cac9aa195574c3d416a40bbdc5ec2d64424e2
Change-Id: Ie605e783b333be0f81099d8d953725c38eb4cee1
2020-05-05 09:44:08 -05:00
Ed Sanders
5271b3eafd
Move CommentController to separate file
...
Change-Id: I6dbf16801058e7e41d38a0ce5753c298d380b780
2020-04-30 17:05:04 +01:00
