wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-12-20 12:02:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
3550 commits 13 branches 4 tags 131 MiB
Commit graph

8 commits

Author SHA1 Message Date
Bartosz Dziewoński a14474ed76 CommentFormatterTest: Set ArticlePath in the test 
Tests would fail if your wiki's config was different than this.

Change-Id: I148851a9d7b777f1fad5f17b01b835b0b9384a80
(cherry picked from commit cf9f11167d)
 2024-05-11 18:45:49 +02:00
Ed Sanders b63884f561 Turn comment timestamps into permalinks 
Bug: T275729
Change-Id: Ica9cfd9743a67fce170e8b078016fa79bf6fbb84
 2023-10-02 14:53:47 +01:00
Derick Alangi 6295079d77 phpunit: Use recent overrideConfigValues() over setMwGlobals() 
Change-Id: I928dc450adb149e4a4a2260482b148c5cd1670c1
 2023-06-02 10:37:15 +03:00
thiemowmde 8bbbf39bbd Make use of named MainConfigNames::… constants 
Also merge setMwGlobals() calls because they are really expensive.

Also utilize the more readable str_contains() and related.

Change-Id: Iebde6aa17c2e366f0c0a98fe13a454f6a06c299b
 2023-05-19 12:12:32 +02:00
Bartosz Dziewoński f68f91e883 Set $wgUsePigLatinVariant = false while running tests 
Data used for the tests assumes there are no variants for English,
and some tests fail when there are. Correct behavior with language
variants is tested using other languages.

Change-Id: I348a0ba0389c2a18644ce5e05c7f37d8f26a8c55
 2021-12-01 23:25:30 +01:00
Alexander Vorwerk 0935bb1271 MediaWikiTestCase -> MediaWikiIntegrationTestCase 
MediaWikiTestCase has been renamed to MediaWikiIntegrationTestCase in 1.34.

Bug: T293043
Change-Id: I485c5c5f0376ab60cdec49e934c6e7eea8c9feb5
 2021-10-12 00:40:27 +02:00
libraryupgrader b0884b177c build: Updating dependencies 
composer:
* mediawiki/mediawiki-codesniffer: 36.0.0 → 37.0.0

npm:
* postcss: 7.0.35 → 7.0.36
  * https://npmjs.com/advisories/1693 (CVE-2021-23368)
* glob-parent: 5.1.1 → 5.1.2
  * https://npmjs.com/advisories/1751 (CVE-2020-28469)
* trim-newlines: 3.0.0 → 3.0.1
  * https://npmjs.com/advisories/1753 (CVE-2021-33623)

Change-Id: I7a71e23da561599da417db3b3077b78d91173bbc
 2021-07-22 16:29:04 +00:00
Bartosz Dziewoński 1c3fada1fb Make CommentUtilsTest a proper unit test 
Documentation:
https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Writing_unit_tests_for_extensions#Two_types_of_tests

We can do this because the tested methods do not depend on any globals
or on MediaWiki being installed.

In addition to being the new hotness, MediaWikiUnitTestCase allows the
test classes that use it instead of MediaWikiTestCase to start up much
faster. In my testing, running this test case individually now takes
0.35s, compared to 1.1s before.

Try:
* With new code:
  time php tests/phpunit/phpunit.php extensions/DiscussionTools/tests/phpunit/unit/CommentUtilsTest.php
* With old code:
  time php tests/phpunit/phpunit.php extensions/DiscussionTools/tests/phpunit/CommentUtilsTest.php

Change-Id: I771b1f3d101a394ee869e42547d9ae7839397752
 2021-02-02 15:37:17 +01:00