Ed Sanders
293cd13018
Fix margins in footer
...
Vector 2022 increased paragraph bottom margin to 1em.
Reset this to 0.5em.
Also don't append an empty links list.
Change-Id: I18b17824cc1093dbf61b354309144be8d9d74643
2024-09-26 17:24:15 +01:00
jenkins-bot
f5f94a9456
Merge "Fix some dark mode issues on mobile"
2024-09-17 01:38:21 +00:00
David Lynch
bb418d6b60
Don't startPoll if there's not a subscribable heading, i.e. New Topic
...
Any save errors wouldn't be shown -- most visibly, this meant any new
topic requiring a captcha couldn't be submitted.
Follow-up to 890cec73b6
2024-09-16 19:26:25 -05:00
Taavi Väänänen
53b77ea9ac
Fix some dark mode issues on mobile
...
Change-Id: I2f2c9da258467a3b1610c25661baa9fdb064f8fd
2024-09-15 11:30:24 +03:00
Ed Sanders
f52841a9e2
Use fixed font size for UI components in Vector 22
...
Bug: T373875
Change-Id: If0e71a7aaf1ea1e0315fc80999541019b3990bb0
2024-09-06 14:53:02 +01:00
Bartosz Dziewoński
890cec73b6
Pause polling for new replies while saving
...
Also fix stopPoll() not really stopping the polling if a request was
in progress while it was called.
Bug: T333576
Change-Id: Ie8f6f006c6fd23971e53586e6219992db23f48fc
2024-08-28 18:55:30 +02:00
Bartosz Dziewoński
f76e47a3ef
Keep sending CAPTCHA info if an unrelated save error happens
...
Bug: T371041
Change-Id: I72c73b0e323c794578edb14efcc9cc06e46a194b
2024-08-27 23:55:15 +02:00
Bartosz Dziewoński
4ff5bf253d
Reattempt the save when something already created a temporary account
...
Bug: T368263
Change-Id: I2adcb83017daff578627aa02b04934be21eade44
2024-08-27 23:49:48 +02:00
Bartosz Dziewoński
5bb03b9e7f
Fix missing definition of setSaveErrorMessage too
...
Follow-up to 6a17f6121c4ec197a8cb
2024-08-27 23:15:06 +02:00
David Lynch
4ec197a8cb
CommentController: fix a call to a missing setSaveErrorMessage
...
Follow-up to 6a17f6121c
2024-08-26 09:15:21 -05:00
jenkins-bot
182c247930
Merge "Show confirmation prompt if trying to submit a new topic without a title"
2024-08-12 17:02:08 +00:00
Jon Robson
f065c46e6b
Dark mode styles should not apply to printed content
...
Bug: T371331
Change-Id: I5bd5e530d1262c7e52e1725959e07776ff9f3704
2024-08-08 20:32:16 +00:00
jenkins-bot
8c9ec66df3
Merge "Fix attachment of toolbar dialogs"
2024-08-06 20:27:30 +00:00
David Lynch
da47997ef4
Fix attachment of toolbar dialogs
...
getToolbarDialogs defaults to the `side` position, but we actually want
the `above` one here.
Bug: T371341
Change-Id: Ib42f6a4877d3b0efb87199f60cce7a7416ce9b8a
2024-08-06 11:39:44 -05:00
Ed Sanders
d8f564fe71
Show confirmation prompt if trying to submit a new topic without a title
...
Bug: T334163
Change-Id: Ib961632636d5b7134219cddde1638c6962209001
2024-08-06 09:44:27 -05:00
Ed Sanders
6a17f6121c
Move reply widget controlling logic to CommentController
...
Some of what happens when you click reply happens in
CommentController (in #save) and some error handling
happens in ReplyWidget (in #onReplyClick).
Move most of the logic to CommenController.
Change-Id: Ib6208c0b8d2ddbbcf08adfcca7875ab8b026f598
2024-08-06 09:44:27 -05:00
Hannah Okwelum
4403887e88
Prepare Less styles for math=parens-division
...
Bug: T368921
Change-Id: I4c6db2d39883d31cf4216da0e3d79136287bf960
2024-07-31 20:12:15 +01:00
Sjoerd de Bruin
f986dc1924
Apply word-wrap:break-word; to .ext-discussiontools-init-pageframe-latestcomment
...
Bug: T369599
Change-Id: I3b1739e4e0ed257dd149d29d9d112983204dde0b
2024-07-09 19:37:30 +02:00
Bartosz Dziewoński
eb497b00c7
permalinks: Only handle unmodified left clicks
...
Allow using Ctrl+click to open the link in a new tab, or Alt+click to
select the text, without annoying side effects.
Change-Id: I3ab4c1ec3d5fc6c69e7f44489bbe63c536a64b91
2024-07-02 10:38:42 +02:00
jenkins-bot
6796c26cc9
Merge "Fix color contrast issues in DiscussionToolsDebug in night theme"
2024-07-01 15:59:54 +00:00
jenkins-bot
1be8a4e281
Merge "Use green rather than yellow for newly posted messages"
2024-07-01 15:59:52 +00:00
jenkins-bot
76dad90e28
Merge "Fixes background of talk page highlights in dark mode"
2024-07-01 15:59:51 +00:00
Jon Robson
b3bb486e30
Fix color contrast issues in DiscussionToolsDebug in night theme
...
Visual change: tokens are switched out for closest available.
Bug: T366524
Change-Id: I185bf496e3b2974ec4cb873719327e6898ca57db
2024-06-28 17:12:52 +00:00
David Lynch
edb23dc849
Permalink copying: fix another reference to e.target
...
Bug: T368701
Change-Id: Iae20e4573dfc12ea9d4010390fe2acb135e1b1cd
2024-06-28 11:05:11 -05:00
David Lynch
cd39c267b5
Permalink copying: use currentTarget to avoid conflicts with userscripts
...
Bug: T368701
Change-Id: I70b1cbf8aaf917ed843f003eec7bbd61db39ecc7
2024-06-28 10:17:27 -05:00
Jon Robson
f81739f8b4
Use green rather than yellow for newly posted messages
...
Use @background-color-success-subtle following discussion
Bug: T368086
Change-Id: I216fdb576ee9066df0c3cd3bc62d424f258fe265
2024-06-27 15:45:34 -07:00
Jon Robson
6896c8c879
Fixes background of talk page highlights in dark mode
...
Bug: T368086
Change-Id: I6ca92afeba448f953d1ef5f54d7f1e966c017b48
2024-06-27 15:45:34 -07:00
bwang
e830713b64
Fix white on white text in source preview
...
Bug: T367432
Change-Id: I2beabfe21e0c7402804a6968d983b8ef96b5329b
2024-06-27 09:51:06 -05:00
Ed Sanders
66ddcf5b64
Remove A/B test code
...
It's unlikely we'll do another feature A/B test any time soon.
Bug: T322492
Bug: T341491
Depends-On: Ia3712e2930fcd971bce44f568430602ce3949f23
Change-Id: I1ef4191f9466b7420a2fead571615ed6d49f873e
2024-06-21 21:08:15 +00:00
jenkins-bot
fb4d4d77a5
Merge "Trim whitespace from truncated heading titles in IDs"
2024-06-20 02:20:23 +00:00
Ed Sanders
9e9ad65f2b
build: Update eslint-config-wikimedia to 0.28.2
...
Change-Id: Ifb0eb261325544fceeb16d13be31bbf303e64124
2024-06-13 17:28:06 +01:00
jenkins-bot
a3adda8ed7
Merge "Remove jquery.makeCollapsible workarounds for mobile"
2024-06-10 19:29:49 +00:00
Ed Sanders
e9f412f4c0
eslint: Remove no-op config
...
Change-Id: Idcc2f4e4edeb57d1fb11deb4e798529f14466c9b
2024-06-06 16:30:49 +01:00
Ed Sanders
39f106ebf4
build: Update stylelint-config-wikimedia to 0.17.1
...
Change-Id: Ie6c51769e5037cd27ec4b04858ad3c2dcf0db81e
2024-06-05 18:36:37 +01:00
Bartosz Dziewoński
2c9264e412
Remove jquery.makeCollapsible workarounds for mobile
...
The module is now loaded normally by the Minerva skin (T111565).
Bug: T323639
Change-Id: I9121410c20fffd651c81c26b84b861ec9300881f
2024-06-04 00:56:58 +02:00
Ed Sanders
bf09928773
build: Update eslint-config-wikimedia to 0.28.0
...
Change-Id: Ie6bcea16debc74d3dd1283f6a4975fb3bd5056b0
2024-06-03 18:37:15 +01:00
Ed Sanders
1900b2d383
Drop IE basic support
...
Use the better method for inserting spaces after the
talk namespace, now that IE support is not required.
Change-Id: Id07e91e13bc0b19c467380e6aa5d3ebd7a4db106
2024-05-30 17:26:26 +01:00
jenkins-bot
ff59532fdc
Merge "Keep all buttons in "reply" group on one line"
2024-05-28 18:26:43 +00:00
Ed Sanders
49aaeba740
Keep all buttons in "reply" group on one line
...
Specifically, the "Reply" button and [...] overflow menu.
Change-Id: I66f9cf01a0ef31f31b28bfe185a39b4d22d69913
2024-05-28 18:37:21 +01:00
Bartosz Dziewoński
9d73c46d99
Percent-decode the permalink when copying
...
Bug: T357021
Change-Id: Ic71c030e6796695de5ff88a940adb86d63996e7f
2024-05-28 18:22:30 +02:00
Ed Sanders
a86897f890
Comment thanking
...
Bug: T249893
Change-Id: I64f7abc26bfc3e7b226340934a637a555edf754f
2024-05-28 17:47:09 +02:00
Ed Sanders
177639f5be
Use Array#push instead of Array#concat
...
Change-Id: I605e726fce1cf1acf39ffdcfe8c7cd51c032a372
2024-05-24 17:28:37 +00:00
Ed Sanders
ea5639b20b
ESLint: Enforce prefer-const
...
Change-Id: I5985d1b532988bb3b71ff1aa24eae57ac2e1b9c5
2024-05-24 16:50:13 +01:00
Ed Sanders
44303de9cf
ESLint: Replace some lets with consts by moving declarations
...
Change-Id: I710bff5fe04268172a40af75eb6ff5910eaf0255
2024-05-24 16:50:13 +01:00
Ed Sanders
dda9227947
ESLint: Manually fix remaining no-var violations
...
Change-Id: I4474bd0205e7a1ed8e60147e52675e3e0b93ccd9
2024-05-24 16:50:11 +01:00
Ed Sanders
ca5157156a
ESLint: Autofix no-var rule
...
Leave rule off for now as manual fixes are required.
Also temporarily disable prefer-const rule as that
will also require some manual fixes.
Change-Id: I8c3478f26f51287acb943bd38c9c1020c06b9f39
2024-05-24 16:49:36 +01:00
jenkins-bot
5689650a6a
Merge "Replace $.extend with Object.assign"
2024-05-02 21:42:02 +00:00
Ed Sanders
1e0aa2171f
Replace $.extend with Object.assign
...
Change-Id: Id559ab68451a1d767e92ed17b1ef0832a5f243af
2024-05-02 16:49:43 +01:00
Ed Sanders
2dd73f935c
JSDoc: {Mixed} -> {any}
...
Change-Id: I78bdc1ec8767dca05e979d8c6ebfed72573acc6f
2024-05-02 10:36:24 +01:00
Ed Sanders
501046f38c
Trim whitespace from truncated heading titles in IDs
...
Bug: T356196
Change-Id: Iddcda0cee624fda7f78a05e0a3d70eaee2635da9
2024-05-01 14:20:12 +01:00
