Commit graph

3413 commits

Author SHA1 Message Date
Bartosz Dziewoński bfe4a81436 Fix [reply] spacing on mobile when usability improvements unavailable
Minerva uses block placement for the buttons only on pages where
usability improvements are available.

Follow-up to 869520a6d0.

Bug: T325416
Change-Id: I9e828197aea7bbaff86489f3ef6e256e0a0845ff
2023-03-23 00:17:18 +01:00
Ed Sanders d31254005f Update linters
Autofix some stylelint inssues

Change-Id: I5200899d253724a61bde127ccb00d8c0108af205
2023-03-22 22:38:41 +00:00
Umherirrender b7c74a34f4 build: Remove unneeded inline stylelint-disable-next-line
modules/dt.ui.ReplyWidget.less
  39:39  ✖  Needless disable for "no-duplicate-selectors"
--report-needless-disables
  65:2   ✖  Needless disable for "no-descending-specificity"
--report-needless-disables
 205:2   ✖  Needless disable for "no-descending-specificity"
--report-needless-disables

Change-Id: I233fdfbed46a9f8e75629d827b00007679063c29
2023-03-22 21:43:31 +01:00
jenkins-bot 47c40f627e Merge "persistRevisionThreadItems: Allow processing all pages in a namespace" 2023-03-22 15:17:45 +00:00
jenkins-bot 3dc8b69fb5 Merge "Bring over deleted message minerva-talk-full-page from Minerva" 2023-03-22 15:12:16 +00:00
Ed Sanders 763dbf63ea Bring over deleted message minerva-talk-full-page from Minerva
We can rename this later, once TranslateWiki has migrated the translations.

Change-Id: Ida5e19eca71dbe9c1b7c8c1bcd1d61f59d744f2b
2023-03-22 14:38:23 +00:00
Translation updater bot ff8cee4ed7 Localisation updates from https://translatewiki.net.
Change-Id: I72183fd9f9502d32a1f85f5d2fe6b8e8e77527e0
2023-03-22 09:15:18 +01:00
Bartosz Dziewoński 174533e41d persistRevisionThreadItems: Allow processing all pages in a namespace
Bug: T332745
Change-Id: I3014c9aab1df5aff6fe36742daef77b3b21a2445
2023-03-21 23:48:52 +01:00
jenkins-bot 35aa38b423 Merge "Use setExtensionData() instead of marker comments where possible (3/3)" 2023-03-21 17:01:28 +00:00
Translation updater bot 62dbb8128b Localisation updates from https://translatewiki.net.
Change-Id: I3850528bf4e28ca9602c5a2df4b99492f0cb0d7e
2023-03-21 09:16:28 +01:00
Bartosz Dziewoński 6bf128cf2d Use setExtensionData() instead of marker comments where possible (3/3)
We started using marker comments (HTML comments with special content
inserted into the page) for the reply buttons back in the day, because
we needed to indicate their location in the HTML. Later we used the
same idea for things which aren't actually tied to a specific location
in the HTML, such as boolean data like __DTEMPTYTALKPAGE__. There is a
better way to do this.

This commit stop writing the HTML comments, which are no longer used,
and cleans up the tests.

Bug: T328980
Change-Id: I37541356830945cc9abcc79d4c445ff6f2449759
(cherry picked from commit ab40ef62c0)
2023-03-21 00:13:01 +01:00
Ed Sanders 80dd6e2d7c Add new topic subscription button to page actions
Bug: T263821
Change-Id: Iab7f7d5fd1f7c229c2e0cda9369676cfd401a24e
2023-03-20 14:51:10 +00:00
Ed Sanders 2bae1864bd New topic notifications
Bug: T263821
Change-Id: Ied465e732122a1ee39ab4510f73aca11ef556c35
2023-03-20 14:41:53 +00:00
Ed Sanders 4367595bfd EventDispatcher: Generate dt-added-topic events
Change-Id: I98b67e016995866558274809743fa21ed23ee063
2023-03-20 14:41:21 +00:00
Translation updater bot fd519ff015 Localisation updates from https://translatewiki.net.
Change-Id: Ic597e9aa7238f1272c8f8240cfcf8888d42d0863
2023-03-20 09:01:03 +01:00
Bartosz Dziewoński dcecf76ff1 Centralize EditAttemptStep logging code in WikimediaEvents
PHP logging code is not moved.

* Use the new mw.track() handlers from WikimediaEvents
* Ensure that 'integration' and 'editor_interface' are set on init
  events, since they're not hard-coded in the handler any more
* Remove the setting of 'editingStatsId' tracking parameter,
  now happens in WikimediaEvents (by way of VE ArticleTargetSaver)
* Remove code connecting ve.track to mw.track, now happens in VE

This must be merged together with WikimediaEvents change
Iace4d53a972396ca5b8713000570cc47c9986034 (but we can't use
Depends-On, because CI requires code here to be removed first).

Bug: T332438
Change-Id: I0ef0a96aafdf89a4ebe32131a85b18c25744bb2c
2023-03-18 13:26:10 +00:00
Translation updater bot b01b172925 Localisation updates from https://translatewiki.net.
Change-Id: I14ad847e8daa62e62a7c3d6c37765612e65a7dcb
2023-03-17 09:22:01 +01:00
jenkins-bot 3ca1a43e2f Merge "Show usernames when display names are matched" 2023-03-16 19:36:49 +00:00
jenkins-bot f05699af82 Merge "ThreadItem: Add display names to getAuthorsBelow" 2023-03-16 19:36:48 +00:00
jenkins-bot 95019f563d Merge "CommentParser: Output display name if different to username" 2023-03-16 19:36:46 +00:00
Ed Sanders 37614a136f Show usernames when display names are matched
Also make our filter function match any substring of
the suggestion index (username + display names), as display
names often contain leading punctuation.

Bug: T266401
Depends-On: I69e5f54f7a8b7ca4126cc3ea513fc96e0a8606fb
Change-Id: I4e7429f8a88c3a82e981f37eb107c2b011482d73
2023-03-16 20:23:42 +01:00
Translation updater bot 8e90cbb700 Localisation updates from https://translatewiki.net.
Change-Id: Icc8dca0cfdb615fe22f7cd85992bd406b0e3518e
2023-03-16 09:27:34 +01:00
jenkins-bot 2185ac1ca3 Merge "Allow visualenhancements on pages with __NEWSECTIONLINK__" 2023-03-15 20:24:19 +00:00
jenkins-bot e87d68f8c0 Merge "Revert "Remove dtenable API hack"" 2023-03-15 16:25:22 +00:00
jenkins-bot 49d3d44ce3 Merge "Use setExtensionData() instead of marker comments where possible (2/3)" 2023-03-15 15:49:38 +00:00
Translation updater bot bb9cf6c384 Localisation updates from https://translatewiki.net.
Change-Id: I957ebd29ab86eb10a6c1d5896c3a93fc0b5693fc
2023-03-15 08:49:40 +01:00
Ed Sanders 12e8d1a17d Allow visualenhancements on pages with __NEWSECTIONLINK__
Exclude the main namespace unless it allows signatures.

Allow this feature to be disabled via config so
we can do a slow rollout.

Bug: T331635
Change-Id: If46bff5620c5245d5b82653ee96282532fd00c28
2023-03-13 15:32:23 +00:00
jenkins-bot 319b5be506 Merge "Disable section toggling on mobile when replying" 2023-03-13 14:41:46 +00:00
Translation updater bot 538aa61574 Localisation updates from https://translatewiki.net.
Change-Id: I35561e67f98fbbef0d83170bab1ff0270f6f85a3
2023-03-13 08:38:47 +01:00
libraryupgrader 3561760067 build: Updating mediawiki/mediawiki-codesniffer to 41.0.0
The following sniffs now pass and were enabled:
* MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic

Change-Id: Ibc7772bf066adb53eaac52b2b5539b418c9618f6
2023-03-12 00:45:46 +00:00
Translation updater bot a654c0c2b4 Localisation updates from https://translatewiki.net.
Change-Id: I82404b581c009d771b82831a299706ea8a983def
2023-03-10 08:48:21 +01:00
jenkins-bot 3fd625a6cc Merge "Allow overflow from section containers on mobile" 2023-03-09 22:54:43 +00:00
David Lynch 722ce7d6be Clicking "reply" was broken
Follow up to I4ee024cc4760542790319f302f42b1b2389ac897

Bug: T269310
Change-Id: Ibb7b3eda52965035ed34b101582fda32f6867ba0
2023-03-09 13:26:33 -06:00
David Lynch fbd5f575a4 Allow overflow from section containers on mobile
The ellipsis buttons in sections on mobile weren't able to properly show
their dropdowns or parts of their highlight because of the section
overflow we applied with visual enhancements. Because this was added for
a block context to contain the floating subscribe links, scope this to
mobile where that shouldn't be a concern.

Bug: T330536
Bug: T330537
Change-Id: Ic9787d6ca622a8f8bfbf9797353129e7fa40f4b7
2023-03-09 10:50:38 -06:00
Translation updater bot aa5a4737d1 Localisation updates from https://translatewiki.net.
Change-Id: Ib080602a7720733a57eab30b0933e22e37dd8352
2023-03-09 09:04:36 +01:00
jenkins-bot 663170fb2d Merge "Support '&preload=...' etc. in new topic tool when '&dtpreload=1' is set" 2023-03-08 20:55:32 +00:00
Translation updater bot eb164a5a26 Localisation updates from https://translatewiki.net.
Change-Id: I4b476ba964beee06cc016fd27befb62ae9c24fb2
2023-03-08 08:42:02 +01:00
Translation updater bot d6ba810891 Localisation updates from https://translatewiki.net.
Change-Id: I594335406e56a3d5e13dc2341312332e182c1563
2023-03-07 08:44:32 +01:00
Ed Sanders 1453c1023d Disable section toggling on mobile when replying
Bug: T320753
Depends-On: I5e199d404b622fae014f1f9489f65464dab8295b
Change-Id: Ib6c92dc96484282fcc0773991b1a0a80fe97e962
2023-03-06 15:01:42 +00:00
Translation updater bot b38cb42a57 Localisation updates from https://translatewiki.net.
Change-Id: I6a2774b1f8bf1bf98b37cedc63a1993bc4a10ba5
2023-03-06 08:33:12 +01:00
Translation updater bot 2fdb6dd928 Localisation updates from https://translatewiki.net.
Change-Id: I69117f790ecd516ef63c74152a06681074d25e66
2023-03-03 09:31:58 +01:00
Translation updater bot 13a79204a8 Localisation updates from https://translatewiki.net.
Change-Id: I9f920da598c6a679deb9388cb51cf870af9ea374
2023-03-03 08:47:42 +01:00
Translation updater bot 8d3f807e2d Localisation updates from https://translatewiki.net.
Change-Id: I455e0662bc0da585959c127f47eb644ac26e86a2
2023-03-02 08:42:40 +01:00
Translation updater bot bc3e40940d Localisation updates from https://translatewiki.net.
Change-Id: Ieec4f00b4138d223a7335796a51886692797ab0e
2023-03-01 08:23:44 +01:00
Translation updater bot 6f26d09d20 Localisation updates from https://translatewiki.net.
Change-Id: Ie0cbddfff7ec3189c9a41f95eb330ef8e9373512
2023-02-28 08:28:49 +01:00
jenkins-bot 2750f2cc53 Merge "Use the new method of getting database object" 2023-02-27 18:24:43 +00:00
Translation updater bot c7537a8367 Localisation updates from https://translatewiki.net.
Change-Id: I9eee44cef05bc81b8581e79704732decabe2b149
2023-02-27 08:27:26 +01:00
Bartosz Dziewoński ffb8e164cb Revert "Remove dtenable API hack"
This reverts commit a1217913ae.

Unfortunately still needed. The reply links can be disabled by just
CSS, but to enable them, we also need to generate the HTML markup,
which isn't done unconditionally. An issue with links disappearing
was reported here:
https://en.wikipedia.org/wiki/Wikipedia_talk:Talk_pages_project#c-Pelagic-20230226035400-PPelberg_(WMF)-20230223000100

Change-Id: I905d3267191193362c278d23145912f4aa0ce139
2023-02-26 22:11:59 +00:00
Bartosz Dziewoński 79675507d2 Remove more unused CSS for .ext-discussiontools-init-replylink-divider
Follow-up to cf6c18f364.

Change-Id: I4af2062e708866ee1b9a0a5947fb5f9eb95c2bbb
2023-02-25 21:31:06 +01:00
Hgzh3 4c0cc92014 Add German aliases for special pages
Change-Id: I864d12c437ed086d4e2f994934a7148167065bc1
2023-02-24 20:15:02 +00:00