4 commits

Author	SHA1	Message	Date
Bartosz Dziewoński	b4029c3c58	Fix signatureRanges overlapping for some comments ... If two signatures for a single comment were near each other, we would sometimes treat them as one huge signature. Change-Id: Ied4b3aa535a9ca6bebef8a004ae48b7d5a8f2f9b	2020-03-09 13:28:22 +00:00
Bartosz Dziewoński	0ca851aa92	parser: Return signature and timestamp ranges ... Currently not used for anything. May be used later for editing comments (T245225) or reformatting timestamps (T240360). Note that a comment may have multiple signatures+timestamps, and we return them all so that you have to deal with that. Fix some unrelated incorrect documentation comments. Bug: T245220 Change-Id: I51b8bf4a3bb7968f35e32c7e44c95c2ab079d9ac	2020-03-05 14:28:17 +01:00
Bartosz Dziewoński	606d6b34ec	Add reply links at the end of a line, even if the signature is in the middle ... Previously they were added at the end of the text node containing the timestamp, which was usually the end of the line, but not always. And also fix the same problem for inserting the actual replies (or reply widgets). This replaces an undocumented hack that prevented our own reply links from triggering this bug (without it, the reply widget would be inserted before the reply link rather than after). While we're here, remove unintentional spacing that appeared before some reply links, caused by trailing whitespace in text nodes. Add tests for all of the above. Bug: T245695 Change-Id: I354b63e2446bb996176a2e3d76abf944127f307e	2020-03-02 21:39:37 +01:00
Bartosz Dziewoński	2a93ed11b4	Rearrange test cases ... I think directories like this make more sense for adding more test cases. Depends-On: I9153851fe162c012967fda00d3e1f81964a8dce9 Change-Id: Ibc72b747a75c72643c1fc04eae49bd15656e8104	2020-02-25 00:19:30 +00:00