Bartosz Dziewoński
af7097f02f
Enable collapsible content in mobile talk page lede content
...
Bug: T323639
Change-Id: I3cfc8e7337172b44156a7f3bed9ff134c0851475
2023-01-03 18:16:15 +00:00
jenkins-bot
8070ce8a57
Merge "a/b test anonymous ID was being reset because of cookie prefixes"
2022-12-22 15:12:25 +00:00
jenkins-bot
477917e7e7
Merge "Only preload getPageData if there's thread data for the page"
2022-12-19 10:08:58 +00:00
David Lynch
013872ae22
Only preload getPageData if there's thread data for the page
...
This should avoid hitting the API if the DT JS is loaded off of talk
pages. At worst, if this is overly restrictive, later calls should still
load it when someone actually interacts with a reply widget.
Bug: T325477
Change-Id: If898dd4a21f1d2620c5a1e79908647070c441854
2022-12-19 03:03:02 -06:00
David Lynch
fcb6468805
a/b test anonymous ID was being reset because of cookie prefixes
...
Bug: T321961
Change-Id: Ie37d0dbefaf10bf48c32461cd7d5d1b4c7882725
2022-12-16 14:45:07 -06:00
David Lynch
0db7b997f3
Log an event when the lede button is clicked
...
Bug: T314596
Change-Id: Ifb5c9eb3cfac8b217546d4945e6f39ce38251e1e
2022-12-15 11:27:26 -06:00
jenkins-bot
459554b18c
Merge "Use new stable API for subtitle modification"
2022-12-14 04:09:58 +00:00
David Lynch
c706562ce9
VisualEnhancements: in some languages put an arrow by the reply button
...
New config: DiscussionTools_visualenhancements_reply_icon_languages
Config is set up with a provide_default merge strategy so we can remove
items from it quickly if need be.
Bug: T323537
Change-Id: Ib748897a2162bb233000f7364e30b268932f4c4a
2022-12-13 00:11:08 -06:00
Jon Robson
fbd951906a
Use new stable API for subtitle modification
...
Bug: T324876
Depends-On: Id8436324e2ae2fd9f488b65b3b7bfc19611870d1
Change-Id: I4b178f67b6718fa9a84827e1804ec4eb1483f735
2022-12-13 01:13:29 +00:00
Bartosz Dziewoński
fda9f159f5
Deemphasize "Learn more about this page" link
...
* Increase selector specificity to make it work
* Tweak colors, they were lighter than intended
* Use color rather than opacity on text to avoid making it blurry
(opacity disables subpixel rendering)
Bug: T324702
Change-Id: Ie32a7481ea90b983cd33e6eae981d47db8612c9f
2022-12-07 22:13:55 +01:00
Francois Pignon
de107bb6a8
Optimize some jQuery selectors
...
Bug: T324523
Change-Id: I57a86f3f29cd33e93db31338420af15fdb3113b9
2022-12-05 23:56:09 +00:00
jenkins-bot
984f804f17
Merge "Don't collapse the lede section when it has comments"
2022-12-05 19:04:37 +00:00
jenkins-bot
8a6bc91f46
Merge "Consider MediaWiki:Talkpageheader message when adding "Learn more" button"
2022-12-05 19:04:35 +00:00
jenkins-bot
e27e5ac55e
Merge "Clear pageDataCache whenever re-initializing"
2022-12-02 11:58:45 +00:00
Bartosz Dziewoński
7dc35aa3ad
CommentController: Fix 'discussiontoolscompare' polling not stopping
...
The .always() callback can be called after .teardown(), and would
previously restart the polling.
Bug: T313096
Change-Id: I6e4c0f7d47e13bd4a259282a508afcdf0c1bd949
2022-12-01 21:12:37 +00:00
Bartosz Dziewoński
37fda5e181
Clear pageDataCache whenever re-initializing
...
Bug: T323661
Change-Id: Ia080f4a8e79551bd16a1ce96f6851a76159d8da7
2022-12-01 21:49:08 +01:00
jenkins-bot
64e5c91970
Merge "Hide buttons for print media"
2022-12-01 15:14:33 +00:00
jenkins-bot
db1aa31eed
Merge "Remove dd overflow hack"
2022-12-01 15:04:09 +00:00
Bartosz Dziewoński
b4475801fd
Don't collapse the lede section when it has comments
...
Bug: T324139
Change-Id: I14e1dae0fef4177f5a6a223bc9b663e99c9f741c
2022-11-30 20:25:22 +01:00
Ed Sanders
7ab0c69f39
Remove support for data-mw-comment
...
Can be merged once I85ee8e6ed6 has been deployed long enough
for all the caches to have been purged.
Change-Id: Ic9773c2e45a4aa796cb6bca52e58d7db1016a977
2022-11-30 18:31:02 +00:00
jenkins-bot
5a524d0fa3
Merge "Track events for the new comment notice"
2022-11-29 19:40:32 +00:00
Bartosz Dziewoński
74fbe19838
Consider MediaWiki:Talkpageheader message when adding "Learn more" button
...
We also need to move the code to the other hook to avoid adding it twice now.
Bug: T324046
Change-Id: I186d15f6e6537b47b019c9707d7ae8ef080f4ae2
2022-11-29 18:46:40 +00:00
Ed Sanders
79537c9892
Ignore negative page scroll values on iOS
...
Bug: T323400
Change-Id: Id37f3da183a08f936c6b6d11ed7307bb9d8bd28b
2022-11-29 14:29:50 +00:00
Bartosz Dziewoński
ea2e519b05
Hide buttons for print media
...
Change-Id: I6f4e5ee66de3a8d62727ae226f3b17a95a0ae2df
2022-11-29 00:36:49 +01:00
jenkins-bot
ea54a8facc
Merge "Use 'BeforePageDisplay' instead of 'OutputPageBeforeHTML' for once-per-page things"
2022-11-28 15:23:52 +00:00
Bartosz Dziewoński
8452f94cf9
Use 'BeforePageDisplay' instead of 'OutputPageBeforeHTML' for once-per-page things
...
Also fix a CSS selector to handle content added in multiple
'OutputPageBeforeHTML' hook calls.
Bug: T323376
Bug: T323833
Change-Id: I480d9bf544d61f0cb7bfd04cadfbf053e7e1b70e
2022-11-25 16:12:16 +00:00
jenkins-bot
eb9631164d
Merge "Place replies outside transclusions, disallow replying to transcluded comments"
2022-11-24 14:00:40 +00:00
Bartosz Dziewoński
46a9a13116
Remove dd overflow hack
...
No longer needed after I73d654d1f9127e22365d94909681c1c5f5f39597.
Change-Id: I2a16b725fca512ccbb72f493fd7db28836341e24
2022-11-23 11:28:14 +00:00
Bartosz Dziewoński
86ffa41af7
highlighter: Fix double-escaping of popup notifications
...
Bug: T323351
Change-Id: Iaa69ccd944114f2a7ff88e01b6e58d70d38cac89
2022-11-18 14:56:36 +01:00
Bartosz Dziewoński
4cebf20e76
CommentFormatter: Fix condition for lede button to consider table of contents
...
(Also fix some related CSS that was accidentally moved in
Ie5198e902ec3fa7a7eba56cef6c6f0ef71ef7314)
Bug: T323241
Change-Id: I1fa67965a1b6b827c500a9de63f5b5295bee840d
2022-11-16 22:18:11 +01:00
jenkins-bot
954dc520b7
Merge "Make "Add topic" button sticky"
2022-11-16 19:06:30 +00:00
David Lynch
84620569dd
Track events for the new comment notice
...
Bug: T301582
Change-Id: I40355502a59a7f31e465e52859b303680c1e109f
2022-11-16 11:49:50 -06:00
Ed Sanders
b132522fa9
Make "Add topic" button sticky
...
Bug: T316175
Change-Id: Ie5198e902ec3fa7a7eba56cef6c6f0ef71ef7314
2022-11-16 12:23:34 +00:00
Bartosz Dziewoński
46d766f30d
Remove override for Minerva hiding .tmbox, no longer needed
...
Depends-On: Ifb0316256bdec5008acc48544ddd3e2bf71b6d41
Bug: T257394
Change-Id: I7b442d2e009f631ec8ac183f4767ffcc1e94954c
2022-11-15 11:26:08 +01:00
Bartosz Dziewoński
469b7720af
Place replies outside transclusions, disallow replying to transcluded comments
...
Bug: T313100
Change-Id: I3993c96ec8d3d0add33d779860d158327985107d
2022-11-14 19:17:18 +01:00
Bartosz Dziewoński
310323b561
Tweak mobile styles for no-JS compatibility
...
Bug: T321430
Change-Id: I0f20750995d89c0bb4be9a70e594326f15a6de0b
2022-11-14 15:01:35 +01:00
Bartosz Dziewoński
f27d173852
Remove some unused CSS
...
No longer needed since the "Subscribe" button was moved elsewhere
(2960853088
2022-11-14 14:57:13 +01:00
Bartosz Dziewoński
04cfffe323
Move visualenhancements metadata and some buttons outside of <h2>
...
We wrap a `<div>` tag around the `<h2>`, and move some elements there.
The markup is inspired by and compatible with my proposal for T13555.
The "ext-discussiontools-init-section" class is moved to the `<div>`.
A small patch is needed in MobileFrontend to preserve the section
collapsing functionality: I11bff21e81046898ca63f3f432797129fa70ad88.
The following elements are now outside of `<h2>`:
* Metadata bar
* Subscribe button
* Ellipsis menu (only shown on mobile)
The following elements are sadly still inside of `<h2>`:
* Subscribe links (only shown on desktop)
* Section edit links from MediaWiki core
Trying to move them mucks up the CSS too much. I hope we can resolve
this later as a part of the work on T13555.
Depends-On: I11bff21e81046898ca63f3f432797129fa70ad88
Bug: T314714
Change-Id: I0bbdcfa02c334858737855349d7a35746de1d8f2
2022-11-10 23:35:40 +01:00
Ed Sanders
e0855e4f41
Make virtual keyboard detection into a body class
...
This allows it to be re-used for other features, such as the
upcoming floating "Add topic" button.
Add some support for Android, although not used in this patch.
Change-Id: Ibd1e1ee087ac607c88a7402d0422c633700d1992
2022-11-10 23:30:53 +01:00
Ed Sanders
8cd239b0b4
Move ...-replylink-open class to <body>
...
This allows elements outside the page container to respond to it.
Change-Id: Id880ada0e24cb803e7b992284a1a95950f3da36f
2022-11-10 23:30:10 +01:00
Ed Sanders
79521f89cf
Add button to reveal lede section on mobile
...
Bug: T312309
Depends-On: I9c3035c9dbe7545a05efb2286dffe0145d3557b4
Change-Id: I9d74914ddbcc9def74e85106a68574a807b0b731
2022-11-10 22:10:04 +00:00
jenkins-bot
af6f6e6149
Merge "Disable "Share feedback..." links by default"
2022-11-08 22:04:08 +00:00
Ed Sanders
b4eb7fc9ad
Disable "Share feedback..." links by default
...
Will still be enabled on WMF wikis for now.
Bug: T322494
Change-Id: Ic0b79fdf459d4949d7604f5a213cb1851ca30901
2022-11-08 21:58:39 +00:00
jenkins-bot
c83bad9de8
Merge "Embed pageThread JSON in jsConfigVars instead of infusing HTML"
2022-11-08 18:59:48 +00:00
jenkins-bot
c0e757c716
Merge "ABtest for mobile, logged out users"
2022-11-08 18:41:38 +00:00
Ed Sanders
a00131a18f
Embed pageThread JSON in jsConfigVars instead of infusing HTML
...
Bug: T322651
Depends-On: I86d461756398780dc24949013f35b7730a481052
Change-Id: I85ee8e6ed6eba97b94f4e4c415fbc5286c234cce
2022-11-08 16:20:39 +00:00
Ed Sanders
317b8244dd
Move username completion tool after special character tool in toolbar
...
Bug: T322455
Change-Id: I19bfe4500850512411615b326b07ba0a47dcfd5f
2022-11-07 13:01:11 +00:00
Bartosz Dziewoński
29fbfb59c3
Tweak mobile "Read as wiki page" button placement
...
Bug: T320755
Change-Id: Ic647ff922161a6f8804dfd2a87249c6591cfb093
2022-10-31 22:30:56 +01:00
David Lynch
9021a45966
ABtest for mobile, logged out users
...
Bug: T320993
Change-Id: I3530c540ec20f8806abcd7010b4d4933d1b53cfc
2022-10-31 16:23:59 -05:00
jenkins-bot
61b89e44a9
Merge "Fix new topic tool appearing from autosave in edit mode"
2022-10-26 16:35:07 +00:00
