wikimedia/mediawiki-extensions-DiscussionTools
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/DiscussionTools synced 2024-12-11 00:02:43 +00:00
Code Issues Packages Projects Releases Wiki Activity
2332 commits 12 branches 4 tags 130 MiB
Commit graph

9 commits

Author SHA1 Message Date
Bartosz Dziewoński af6e4a29eb ApiDiscussionToolsPageInfo: Fix fake headings with null name/id 
name and id are supposed to never be null. Calling getName() or
getId() on this object would cause an exception.

Change-Id: I5f95b7d9e4ce4550b550ee758fc86f032b676731
 2022-06-29 02:52:31 +02:00
Ed Sanders 0ad9b4c6b2 Move placeholder heading level (99) to a constant 
Change the HeadingItem constructor to take a 'null' headingLevel
and store this internally with the constant. Change the JSON
serializer to convert this back to null.

Change-Id: I27508eed75d94b99c5189548919309f8da7deb75
 2022-06-14 22:51:49 +01:00
Ed Sanders ab05e4e24f Add test coverage for ApiDiscussionToolsPageInfo::getThreadItemsHtml 
Change-Id: I46a58f6a2ec5f0e1b750c67e85d27081f5fab544
 2022-06-06 18:40:30 +01:00
Bartosz Dziewoński 8de940b587 Improve detecting transcluded comments again 
Previously: 569db3603c (2020-06).

Unfortunately we've found cases where the previous implementation
doesn't work correctly, resulting in comments being added to the wrong
pages or page corruption.

Bug: T289873
Bug: T298051
Change-Id: Id867b3005ebc46906d6df852a525fcaec9e6b19b
 2022-01-11 16:07:44 +00:00
Ed Sanders 4a0802065c Make IDs (to be used as URL hashes) wikitext safe 
* Use hyphens instead of pipes a separators
* Use underscores for spaces in usernames

Change-Id: I6efd9739fc73e45002e50e64c43ce0de1c2f1239
 2021-03-18 20:45:21 +01:00
Ed Sanders 47aea0b160 Use tabs for indentation in JSON test files 
Change-Id: I1d8f8b33b19bcff249ad08dfe687f87f5e5bf9bf
 2021-01-27 00:25:15 +00:00
Bartosz Dziewoński b09bbfe668 Disambiguate comments by parent ID, rather than sequential numbers 
Sequential numbers aren't great because they change when an earlier
comment is archived. Parent comment/heading IDs should change less
often.

This also makes much more sense for disambiguating subsections,
e.g. a dozen identical ===Votes=== sections for a dozen proposals.

Bug: T264478
Change-Id: I466454984fd919ebef35f2b37ddb5d86dc842996
 2020-10-22 02:19:21 +02:00
Bartosz Dziewoński 9ee0fd69f5 Allow headings to have IDs 
Previously, only comments could have IDs, because we only needed IDs
for replying. But we might also use them for notifications soon.

Bug: T264478
Change-Id: I1bcad02bf17ab54bc5028a959543c10f0430836b
 2020-10-22 02:04:28 +02:00
Ed Sanders c5d1029b25 Move /cases and /data up to /tests 
Theses are no longer QUnit specific.

Change-Id: I5f3cca1ff686922e0cdaaedb80858f37df04799a
 2020-05-18 21:47:17 +01:00